Squiz.Arrays.ArrayBracketSpacing is removing some comments during fixing #1694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code now removed was outdated. It was previously necessary to distinguish a "normal" square open bracket from a short array open bracket, but since the introduction of the `T_SHORT_ARRAY_OPEN` token, this is no longer necessary.
The parse error/live coding check is now applied to both open as well as close brackets.
Includes adjusted and additional unit tests.
jrfnl
changed the title
jrfnl
changed the title
gsherwood
changed the title
|
Thanks a lot for doing that. |
jrfnl
deleted the
feature/issue-1673-2-dont-remove-comments-in-array-brackets
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #1673 (comment), this PR addresses the
Squiz.Arrays.ArrayBracketSpacingsniff unintentionally removing comments which were placed adjacent to the brackets.This should not happen anymore once this PR has been merged.
Includes adjusted and additional unit tests.
While looking at the sniff, I noticed two other improvements begging to be made 😻
Both of these additional issues have been fixed in separate commits.