Fixed bug #2975 : Undefined offset in PSR12.Functions.ReturnTypeDeclaration when checking function return type inside ternary

Author: gsherwood

src/Standards/PSR12/Tests/Functions/ReturnTypeDeclarationUnitTest.inc

@@ -62,3 +62,5 @@ function functionName(?string $arg1, ?int &$arg2):
 ?string {}
 
 fn (?\DateTime $arg) : ?\DateTime => $arg;
+
+return (!$a ? [ new class { public function b(): c {} } ] : []);

src/Standards/PSR12/Tests/Functions/ReturnTypeDeclarationUnitTest.inc.fixed

@@ -58,3 +58,5 @@ function functionName(?string $arg1, ?int &$arg2): ?string {}
 function functionName(?string $arg1, ?int &$arg2): ?string {}
 
 fn (?\DateTime $arg): ?\DateTime => $arg;
+
+return (!$a ? [ new class { public function b(): c {} } ] : []);

src/Tokenizers/PHP.php

@@ -1574,7 +1574,7 @@ function return types. We want to keep the parenthesis map clean,
                 // Convert colons that are actually the ELSE component of an
                 // inline IF statement.
                 if (empty($insideInlineIf) === false && $newToken['code'] === T_COLON) {
-                    // Make sure this isn't the return type separator of a closure.
+                    // Make sure this isn't a return type separator.
                     $isInlineIf = true;
                     for ($i = ($stackPtr - 1); $i > 0; $i--) {
                         if (is_array($tokens[$i]) === false
@@ -1600,12 +1600,15 @@ function return types. We want to keep the parenthesis map clean,
                         }
 
                         // We've found the open parenthesis, so if the previous
-                        // non-empty token is FUNCTION or USE, this is a closure.
+                        // non-empty token is FUNCTION or USE, this is a return type.
+                        // Note that we need to skip T_STRING tokens here as these
+                        // can be function names.
                         for ($i--; $i > 0; $i--) {
                             if (is_array($tokens[$i]) === false
                                 || ($tokens[$i][0] !== T_DOC_COMMENT
                                 && $tokens[$i][0] !== T_COMMENT
-                                && $tokens[$i][0] !== T_WHITESPACE)
+                                && $tokens[$i][0] !== T_WHITESPACE
+                                && $tokens[$i][0] !== T_STRING)
                             ) {
                                 break;
                             }
@@ -1614,7 +1617,7 @@ function return types. We want to keep the parenthesis map clean,
                         if ($tokens[$i][0] === T_FUNCTION || $tokens[$i][0] === T_FN || $tokens[$i][0] === T_USE) {
                             $isInlineIf = false;
                             if (PHP_CODESNIFFER_VERBOSITY > 1) {
-                                echo "\t\t* token is function return type, not T_INLINE_ELSE".PHP_EOL;
+                                echo "\t\t* token is return type, not T_INLINE_ELSE".PHP_EOL;
                             }
                         }
                     }//end if