Fixed bug #3003 : Squiz.Formatting.OperatorBracket autofix incorrect when assignment used with null coalescing operator

Author: gsherwood

package.xml

@@ -78,6 +78,7 @@ http://pear.php.net/dtd/package-2.0.xsd">
     -- Thanks to Michael S for the patch
   - Fixed bug #2913 : Generic.WhiteSpace.ScopeIndent false positive when opening and closing tag on same line inside conditional
   - Fixed bug #2992 : Enabling caching using a ruleset produces invalid cache files when using --sniffs and --exclude CLI args
+  - Fixed bug #3003 : Squiz.Formatting.OperatorBracket autofix incorrect when assignment used with null coalescing operator
   - Fixed bug #3145 : Autoloading of sniff fails when multiple classes declared in same file
   - Fixed bug #3157 : PSR2.ControlStructures.SwitchDeclaration.BreakIndent false positive when case keyword is not indented
   - Fixed bug #3163 : Undefined index error with pre-commit hook using husky on PHP 7.4

src/Standards/Squiz/Sniffs/Formatting/OperatorBracketSniff.php

@@ -330,6 +330,10 @@ public function addMissingBracketsError($phpcsFile, $stackPtr)
 
         $before = $phpcsFile->findNext(Tokens::$emptyTokens, ($before + 1), null, true);
 
+        // A few extra tokens are allowed to be on the right side of the expression.
+        $allowed[T_EQUAL] = true;
+        $allowed[T_NEW]   = true;
+
         // Find the last token in the expression.
         for ($after = ($stackPtr + 1); $after < $phpcsFile->numTokens; $after++) {
             // Special case for plus operators because we can't tell if they are used

src/Standards/Squiz/Tests/Formatting/OperatorBracketUnitTest.inc

@@ -173,4 +173,6 @@ $test = myfunc(1 * static::TEST);
 
 $errorPos = $params[$x]?->getLine() + $commentStart;
 
+$foo = $this->gmail ?? $this->gmail = new Google_Service_Gmail($this->google);
+
 exit -1;

src/Standards/Squiz/Tests/Formatting/OperatorBracketUnitTest.inc.fixed

@@ -173,4 +173,6 @@ $test = myfunc(1 * static::TEST);
 
 $errorPos = ($params[$x]?->getLine() + $commentStart);
 
+$foo = ($this->gmail ?? $this->gmail = new Google_Service_Gmail($this->google));
+
 exit -1;

src/Standards/Squiz/Tests/Formatting/OperatorBracketUnitTest.php

@@ -67,6 +67,7 @@ public function getErrorList($testFile='OperatorBracketUnitTest.inc')
                 165 => 2,
                 169 => 1,
                 174 => 1,
+                176 => 1,
             ];
             break;
         case 'OperatorBracketUnitTest.js':