Squiz.PHP.DisallowMultipleAssignmentsSniff: Fixed false positive when assigment is after goto label

Author: kukulich

src/Standards/Squiz/Sniffs/PHP/DisallowMultipleAssignmentsSniff.php

@@ -146,6 +146,7 @@ public function process(File $phpcsFile, $stackPtr)
 
         if ($tokens[$varToken]['code'] === T_VARIABLE
             || $tokens[$varToken]['code'] === T_OPEN_TAG
+            || $tokens[$varToken]['code'] === T_GOTO_LABEL
             || $tokens[$varToken]['code'] === T_INLINE_THEN
             || $tokens[$varToken]['code'] === T_INLINE_ELSE
             || $tokens[$varToken]['code'] === T_SEMICOLON

src/Standards/Squiz/Tests/PHP/DisallowMultipleAssignmentsUnitTest.inc

@@ -98,3 +98,13 @@ function ($html) {
         return $all;
     }, $html);
 };
+
+
+function () {
+    $a = false;
+
+    some_label:
+
+    $b = getB();
+};
+