You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
it'd be quite useful to include codesniffer in a few of my applications for testing purposes. unless there are any objections, i'd like to get around to adding support for a commonjs-style require of codesniffer. thoughts?
The text was updated successfully, but these errors were encountered:
I believe the PhantomJS code that was originally contributed by one of my colleagues [to me, not when it was posted on here] was written at a time when PhantomJS did not support CommonJS modules, but it appears that PhantomJS 1.7+ does now support them, and I think that for encapsulation's sake - if for our PhantomJS runner at least - it would be a good idea for running customised scripts based on that runner.
If you are expecting a CommonJS module that can be used in other interpretations of CommonJS (like node.js), then I'm not sure that will work. I can't say for sure, but it's unlikely due to our dependence in that script for PhantomJS' headless browser.
Resolved with f79cf0a. It should be noted that HTML_CodeSniffer still requires a browser environment which means that requiring it directly in Node will still result in an error.
it'd be quite useful to include codesniffer in a few of my applications for testing purposes. unless there are any objections, i'd like to get around to adding support for a commonjs-style
require
of codesniffer. thoughts?The text was updated successfully, but these errors were encountered: