Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search fails if term is a tag and comes after a numeric tag #7750

Closed
4 tasks done
myrho opened this issue Nov 25, 2024 · 2 comments
Closed
4 tasks done

Search fails if term is a tag and comes after a numeric tag #7750

myrho opened this issue Nov 25, 2024 · 2 comments
Labels
bug Issue reports a bug resolved Issue is resolved, yet unreleased if open

Comments

@myrho
Copy link

myrho commented Nov 25, 2024

Context

No response

Bug description

Search fails if the term is a tag and comes after a numeric tag in a documents tags list.

In the console I get:

Invalid query: k – see https://bit.ly/2s3ChXG
TypeError: s.slice is not a function

Related links

Reproduction

9.5.46-search-fails-if-term-appears-as-a-tag-after-a-numeric-tag.zip

Steps to reproduce

Install as in the reproduction zip.

Perform a search for "foo". No results are found although the index.html should be listed in the results.

Browser

No response

Before submitting

@squidfunk squidfunk added the needs investigation Issue must be investigated by the maintainers label Nov 25, 2024
@squidfunk
Copy link
Owner

Thanks for reporting! Fixed in d468344. I'm not sure why this did not occur until now, because it is such a common case. The problem was that numeric tags where not converted to strings, which does not work with a search that works on strings.

@squidfunk squidfunk added bug Issue reports a bug resolved Issue is resolved, yet unreleased if open and removed needs investigation Issue must be investigated by the maintainers labels Nov 25, 2024
@squidfunk
Copy link
Owner

Released as part of 9.5.47.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue reports a bug resolved Issue is resolved, yet unreleased if open
Projects
None yet
Development

No branches or pull requests

2 participants