-
Notifications
You must be signed in to change notification settings - Fork 572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Field presence support for proto3 #1497
Milestone
Comments
Does this affect the encoding on the wire? what happens on a |
Looks like the doc has been posted describing this: https://github.com/protocolbuffers/protobuf/blob/master/docs/field_presence.md |
Yes. That's the doc. |
Merged
Thanks guys! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Google will update the proto3 syntax to support "optional" for field presence:
Summary
Add field presence to proto3 in a backward-compatible way by introducing the optional keyword with the same semantics as proto2.
.proto syntax changes
Users can put
optional
on any proto3 field, with syntax and semantics identical to proto2:Public announcement will come soon. Can we support this for proto3?
Removing line 299 - 301 would be OK.
https://github.com/square/wire/blob/master/wire-library/wire-schema/src/commonMain/kotlin/com/squareup/wire/schema/internal/parser/ProtoParser.kt#L299
The text was updated successfully, but these errors were encountered: