fix: add bundler to package #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## beta #74 +/- ##
=======================================
Coverage 82.45% 82.45%
=======================================
Files 2 2
Lines 57 57
Branches 15 15
=======================================
Hits 47 47
Misses 10 10 Continue to review full report at Codecov.
|
JHKennedy4
approved these changes
Feb 22, 2022
|
🎉 This PR is included in version 1.0.0-beta.7 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
1 task
alexandersmanning
added a commit
that referenced
this pull request
Jul 12, 2022
* beta: Update websdk-types dependency (#81) chore(deps): bump ansi-regex from 3.0.0 to 3.0.1 in /examples/tsdx (#88) chore(deps): bump nanoid from 3.1.23 to 3.3.2 in /examples/tsdx (#87) chore(deps): bump minimist from 1.2.5 to 1.2.6 in /examples/tsdx (#86) chore(deps): bump trim-off-newlines from 1.0.1 to 1.0.3 (#78) chore(deps): bump node-fetch from 2.6.1 to 2.6.7 (#77) fix: add bundler to package (#74) chore(deps): bump @commitlint/config-conventional from 11.0.0 to 12.1.4 (#28) chore(deps): bump lint-staged from 10.5.4 to 11.0.0 (#24) chore(deps): bump @babel/preset-env from 7.12.17 to 7.14.7 (#23) chore(deps): bump pinst from 2.1.4 to 2.1.6 (#21) chore(deps): bump conventional-changelog-conventionalcommits (#20) chore(deps): bump eslint from 7.20.0 to 7.29.0 (#18) chore(deps): bump @commitlint/cli from 11.0.0 to 12.1.4 (#13) chore(deps): bump babel-jest from 26.6.3 to 27.0.2 (#19) chore(deps): bump semantic-release from 17.3.9 to 17.4.4 (#17) chore(deps): bump husky from 5.0.9 to 6.0.0 (#14)
|
🎉 This PR is included in version 2.0.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please explain the changes you made here.
This adds a bundler in regards to the issue brought up in #67
The WebSDK library did not work with Webpack 5 due to file extensions missing for modules. The solution the developer provided was to add a
.jsfile extension within the.tsfile. The reason they do this is because tsc (Typescript Compiler) does not add the.jsextension onto imports, and will not change.tsimports into.jsimports. See the below linkmicrosoft/TypeScript#16577 (comment)
The developer was kind enough to provide the above solution, which does work, but is not a long term solution to the real issue: That we need to bundle the code.
tscis a compiler, but it isn’t a bundler, which means that it does not do the following: Polyfill old code. We specify ES6 in our TSConfig, but tsc actually won’t handle cases where ES7+ code is used (e.g. Object.entries). This means Square cannot target browsers and instead the code may break with slightly older browsers (1+ year old) if Square is not careful.Does this close any currently open issues?
Yes: #67