Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to set both hostName and url on datasource resulting in missing fields in metadata #76

Open
david-valaczkai-solidatus opened this issue Jan 25, 2023 · 0 comments

Comments

@david-valaczkai-solidatus
Copy link

david-valaczkai-solidatus commented Jan 25, 2023

TSQLDataSource doesn't allow setting both a url and hostName/port. When a URL is passed to the constructor, the hostName and port fields don't get populated and this results in missing fields in the retrieved metadata.

The database field should probably also get populated.

public TSQLDataSource(EDbVendor vendor, Class<?> driver, String jdbcUrl, String account, String password) {
        this.timeout = 60000L;
        this.enableQueryHistory = false;
        this.min = 30;
        this.duplicateQueryHistory = 0;
        Runtime.getRuntime().addShutdownHook(new NamelessClass_1());
        this.vendor = vendor;
        this.driver = driver;
        this.jdbcUrl = jdbcUrl;
        this.dbCategory = (String)DbTypeConstant.vendorTypes.get(vendor);
        this.dbType = this.dbCategory;
        this.account = account;
        this.password = password;
        this.port = null;
        this.database = null;
        this.hostName = null;
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant