Skip to content
This repository has been archived by the owner on Mar 15, 2021. It is now read-only.

Support for Sqlite #26

Closed
arkhan opened this issue Jun 14, 2016 · 12 comments
Closed

Support for Sqlite #26

arkhan opened this issue Jun 14, 2016 · 12 comments

Comments

@arkhan
Copy link

arkhan commented Jun 14, 2016

Hello, great work,

It's posible to add Support to SQLite data bases

Thanks

@arkhan arkhan changed the title Support fro Sqlite Support for Sqlite Jun 14, 2016
@BornaP
Copy link
Member

BornaP commented Jun 14, 2016

It is, should be quite easy actually. After finding right Node module for SQLite, rest of the work is implementing API which should be very similar to SQL Server implementation I guess. So more or less copy and rewrite :)

I don't have time for this right now, so if you want feel free to contribute! Pull request is welcome!

(Else, if it remains unresolved I'll implement this when I catch some more time.)

@AngeloR
Copy link

AngeloR commented Jun 22, 2016

Would this module be ok as a base? https://www.npmjs.com/package/sqlite

@maxcnunes
Copy link
Member

Maybe is better use the original package https://github.com/mapbox/node-sqlite3

@AngeloR
Copy link

AngeloR commented Jun 22, 2016

The reason I opted for the sqlite module instead of the sqlite3 module was more to ensure a standard programming style. Yes it is an additional layer of dependency, but using the wrapper ensures that the client can take advantage of es6 and be written in a similar manner as the rest of the clients. I felt that it would make maintaining the codebase easier.

@maxcnunes
Copy link
Member

Yeah makes sense. But most of the DB clients we use today are using callback instead of Promise. And we wrap them with Promise inside the sqlectron-core:

My only concern of using the original package is maintainability and have full support of the available functions. In case the API of the original package change or they fix something, we do not depend on this other package to get the latest version.

@AngeloR
Copy link

AngeloR commented Jun 22, 2016

Ok, I'll use the original sqlite3 package instead for this PR.

@thisispiers
Copy link

+1

There aren't any great cross-platform SQLite GUIs. I'd really appreciate the feature so I've posted a bounty of $15.

@maxcnunes
Copy link
Member

@thisispiers thanks for the incentive :)

@maxcnunes maxcnunes self-assigned this Jan 9, 2017
@maxcnunes
Copy link
Member

Anyone interested in this feature. Please tests your queries (simple and complex) here and let me know if there is any bug. We need to use that because the sqlite module does not have a single function that is able to return results and return the inserted/affected rows at same time. With this package we are able to break down the queries and distinguish its type so we know what function use for each query.

@maxcnunes
Copy link
Member

Finished.
Commit 770b06c

@thisispiers
Copy link

Wow! Thanks Max.

@BornaP
Copy link
Member

BornaP commented Jan 20, 2017

Good job Max!!!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants