Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install-DbaInstance, no need to do things twice #5723

Merged
merged 1 commit into from
Jun 11, 2019
Merged

Install-DbaInstance, no need to do things twice #5723

merged 1 commit into from
Jun 11, 2019

Conversation

niphlod
Copy link
Contributor

@niphlod niphlod commented Jun 11, 2019

Type of Change

  • Bug fix (non-breaking change, fixes #)
  • New feature (non-breaking change, adds functionality)
  • Breaking change (effects multiple commands or functionality)
  • Ran manual Pester test and has passed (`.\tests\manual.pester.ps1)
  • Adding code coverage to existing functionality
  • Pester test is included
  • If new file reference added for test, has is been added to github.com/sqlcollaborative/appveyor-lab ?
  • Nunit test is included
  • Documentation
  • Build system

Purpose

Update-ServiceCredential needed silencing in place.
Checking for path being a network one was done in two places, removed one

@potatoqualitee
Copy link
Member

/cc @nvarscar

@potatoqualitee potatoqualitee merged commit 98c8776 into dataplat:prerelease Jun 11, 2019
@niphlod niphlod deleted the pssa/Install-DbaInstance branch September 1, 2020 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@niphlod @potatoqualitee