Errors when database is not present/incorrect.

[shaneis]

Type of Change

• Bug fix (non-breaking change, fixes #)
• New feature (non-breaking change, adds functionality)
• Breaking change (effects multiple commands or functionality)
• Ran manual Pester test and has passed (`.\tests\manual.pester.ps1)
• Adding code coverage to existing functionality
• Pester test is included
• If new file reference added for test, has is been added to github.com/sqlcollaborative/appveyor-lab ?
• Nunit test is included
• Documentation
• Build system

Purpose

If a database that is not present/incorrect is passed into New-DbaDbUser, the function should error out.
This is different from the silently returning that it was originally doing.

Attempted to add a Pester Unit test for this but it would not throw. Added a -Skip to the test until I can figure out what is causing it issues.

Approach

Code now has a if ($null -eq $databases -or $databases.Count -eq 0) { Stop-Function... } block to error out.

Commands to test

New-DbaDbUser -SqlInstance < instance name > -database 'FakeyMcFakeFake' -User 'ItDoesn'tMatter'

Screenshots

Learning

[potatoqualitee]

awww yeahhhh! thank you 🙇