Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DbaServer Rename #4580

Closed
potatoqualitee opened this issue Nov 19, 2018 · 10 comments · Fixed by #5612
Closed

DbaServer Rename #4580

potatoqualitee opened this issue Nov 19, 2018 · 10 comments · Fixed by #5612

Comments

@potatoqualitee
Copy link
Member

The name never sat right with me. I'd like to change a few of these

image

ServerAudit -> Audit and then make a DbAudit <-- for sure
ServerAuditSpecificiation -> Audit and then make a DbAuditSpecificiation <-- for sure
ServerTrigger -> Trigger. DbTrigger already exists <-- questionable
ServerRole -> Role, then make a DbRole
ServerRoleMember -> RoleMember. DbRoleMember already exists

@csolje
Copy link

csolje commented Dec 7, 2018

The Names reflects pretty good with what the same feature is called on the Sql Server

@potatoqualitee
Copy link
Member Author

i'd still like to go forward but it turns out there are breaking changes so going to put this on hold till closer to 1.0

@shaneis
Copy link
Contributor

shaneis commented May 24, 2019

Isn't there an inherent difference between ServerTrigger & ServerRole and DbTrigger & DbRole i.e. the former being server based and the latter being database based?

To distinguish the difference, you'd need something like Server in there, or maybe Srv for brevity.

I was going to suggest adding a switch parameter -Server if you want to do something server based but I'd say that's too hidden away so wouldn't be discover-able enough for PowerShell.

@potatoqualitee
Copy link
Member Author

yeah, they are there for legit reasons. i guess im just iffy on the word Server? Should it be Instance? But they are called Server in SMO i think

@potatoqualitee
Copy link
Member Author

and thank you!

@NakedPowerShell
Copy link

I believe that whatever you pick will be the right choice. So I can live with either Server or Instance

@garethnewman
Copy link
Contributor

I prefer Instance but can live with either :)

@potatoqualitee
Copy link
Member Author

thank you all, i think im leaning instance since server never sat right ❤️

@NakedPowerShell
Copy link

To ship is to choose :}

@potatoqualitee
Copy link
Member Author

k going instance, doing this now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants