Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency in data types during decoding/encoding #63

Open
lisachenko-indriver opened this issue Mar 14, 2023 · 3 comments
Open

Inconsistency in data types during decoding/encoding #63

lisachenko-indriver opened this issue Mar 14, 2023 · 3 comments

Comments

@lisachenko-indriver
Copy link

lisachenko-indriver commented Mar 14, 2023

Vitess uses this library for encoding/decoding data from JSON columns during replication of data. We have faced an issue with data consistency between our original database and data, which was replicated via Vitess. Surprisingly, issue originated from this library.

See relevant issues and PRs in Vitess to find more details:

vitessio/vitess#8686
vitessio/vitess#9508

I think this can be also fixed in you library to avoid issues with type switching in the feature. See this fork from @rohit-nayak-ps which has adressed this master...rohit-nayak-ps:ajson:master

@spyzhov
Copy link
Owner

spyzhov commented Mar 14, 2023

Thanks for sharing! Will check the fork and try to migrate it to the library.

Also, be aware that I just closed bug #61, please do not forget to update the fork.

@spyzhov
Copy link
Owner

spyzhov commented Mar 17, 2023

@rohit-nayak-ps, I saw you'd created a new branch master...rohit-nayak-ps:ajson:vitess-integer-types will you prepare a PR for those changes? I can fix most of the underlying dependencies (in the math mostly) to do new types compatible with the Numeric type.

@rohit-nayak-ps
Copy link

Thanks for checking. We found a separate issue with MySQL JSON datatypes for arbitrary precision numeric/decimal data. I have a fix in progress for that. I will create a PR including that as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants