Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Use .format() to format floats in array and dataframe editors #20473

Merged
merged 5 commits into from
Feb 4, 2023
Merged

PR: Use .format() to format floats in array and dataframe editors #20473

merged 5 commits into from
Feb 4, 2023

Commits on Feb 3, 2023

  1. Rename variable 'format' to 'format_spec' 

    This is to prevent shadowing the built-in function format()
    @jitseniesen
    jitseniesen committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    f7a98ec View commit details
    Browse the repository at this point in the history

  2. Use .format() to format floats in array and dataframe editors 

    This replaces the use of the older and less powerfull % operator
to format floats.
    @jitseniesen
    jitseniesen committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    575b11c View commit details
    Browse the repository at this point in the history

  3. Remove initial '%' character from format_spec

    @jitseniesen
    jitseniesen committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    c69cbee View commit details
    Browse the repository at this point in the history

  4. Remove unused import

    @jitseniesen
    jitseniesen committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    dc47ea2 View commit details
    Browse the repository at this point in the history

Commits on Feb 4, 2023

  1. Fix formats of complex numbers and bools in array editor 

    There is no format specification 'r', but complex numbers can
use the same format specifications as real numbers. An empty
format specification just uses the str() representation.
    @jitseniesen
    jitseniesen committed Feb 4, 2023
    Configuration menu
    Copy the full SHA
    6153bc2 View commit details
    Browse the repository at this point in the history