Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sphinx html_use_smartypants is deprecated as of 1.6 and removed in 1.7 #6570

Closed
csabella opened this issue Mar 2, 2018 · 2 comments
Closed

Comments

@csabella
Copy link
Contributor

csabella commented Mar 2, 2018

http://www.sphinx-doc.org/en/stable/config.html#confval-smartquotes

This is used in spyder/utils/help/conf.py

@ccordoba12
Copy link
Member

@csabella, could this be related to issue #6549?

@csabella
Copy link
Contributor Author

csabella commented Mar 2, 2018

@ccordoba12 I don't think if it will fix #6549, but I don't know that for sure. I can get into the Tutorial on Linux regardless of my version of Sphinx.

I should have included this in the original report. I got the warning running the test for the help plugin.

spyder/plugins/tests/test_help.py::test_no_docs_message
  /home/cheryl/anaconda3/envs/spyder-dev/lib/python3.6/site-packages/sphinx/environment/__init__.py:683: RemovedInSphinx17Warning: html_use_smartypants option is deprecated. Smart quotes are on by default; if you want to disable or customize them, use the smart_quotes option in docutils.conf.
    RemovedInSphinx17Warning)

spyder/plugins/tests/test_help.py::test_no_further_docs_message
  /home/cheryl/anaconda3/envs/spyder-dev/lib/python3.6/site-packages/sphinx/environment/__init__.py:683: RemovedInSphinx17Warning: html_use_smartypants option is deprecated. Smart quotes are on by default; if you want to disable or customize them, use the smart_quotes option in docutils.conf.
    RemovedInSphinx17Warning)

-- Docs: http://doc.pytest.org/en/latest/warnings.html

With the patch and on 1.6.3, the warning goes away. Oddly, without the patch and on Sphinx 1.7.1, the tests run fine. I guess it just ignores the setting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants