Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editors not gaining focus when changing by tab click #4597

Closed
goanpeca opened this issue Jun 13, 2017 · 4 comments
Closed

Editors not gaining focus when changing by tab click #4597

goanpeca opened this issue Jun 13, 2017 · 4 comments
Assignees
Milestone

Comments

@goanpeca
Copy link
Member

With 2 or more files open on the editor, clicking on different tabs should give the focus to the editor (cursor should start blinking) and the outline explorer should update because of this focus gain. Currently the focus is not given to the editor. This does works with the file switcher.

This is on 3.x but not on 3.1.x.

@ccordoba12
Copy link
Member

@dalthviz, please take a look at this one. Since this is a bug that appeared in 3.x, please use git bisect to detect the commit that introduced it.

@rlaverde
Copy link
Member

rlaverde commented Jun 13, 2017

I introduced this bug in 2228e83 while fixing #1170, giving the focus to the Editor caused the unwanted scrolling, should we revert it?

@goanpeca
Copy link
Member Author

@ccordoba12 ?

@ccordoba12 ccordoba12 assigned rlaverde and unassigned dalthviz Jun 13, 2017
@ccordoba12
Copy link
Member

No, we should find a new way to give focus to the current tab. #1170 was very annoying.

@rlaverde, please work on this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants