Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align boxes for different lines in preferences dialog #2481

Closed
goanpeca opened this issue Jun 11, 2015 · 9 comments
Closed

Align boxes for different lines in preferences dialog #2481

goanpeca opened this issue Jun 11, 2015 · 9 comments

Comments

@goanpeca
Copy link
Member

The following image displays the look of the preferences dialog (master). The idea is to use a QGridLayout to align for example, the first three options that include comboboxes.

image

@SylvainCorlay
Copy link
Member

👍

@Nodd
Copy link
Contributor

Nodd commented Jun 11, 2015

QFormLayout is more appropriate, but the difference is subtle: on some platforms the labels are left aligned and on others the label are right aligned, and QFormLayout takes care of it.
I know 2 problems with this layout: it is limited to 2 columns, and keeps the margins for hidden widgets, which creates lines of unequal heights. But neither should be a problem here.

@ccordoba12
Copy link
Member

+1 from me too.

@goanpeca
Copy link
Member Author

@Nodd thanks for pointing me to that layout, but I think that it would look weird to have some things alignes to the left and some others to the right. Since many of these options involve several widgets to the right, I will stick to the GridLayout.

Should be a fast fix, it really bugs me how it looks... it looks ugly!!!

@goanpeca
Copy link
Member Author

@spyder-ide/core-developers

So, I thought it was simpler, cause the helpers for comboboxes already create inside the label, so I added a couple of arguments, to pass along the related labels and any intermediate additional space. I could also, potentially pass the options in comboboxes of related comboboxes so that the width of the actual combobox is also uniform (to the maximum content). So far it would look like this...

pref

@goanpeca
Copy link
Member Author

Or we could just stretch the comboboxes, so all comboboxes reach the same place.

Qt windows style |                                     |
Icon theme |                                           |
Language |                                             |

@goanpeca
Copy link
Member Author

I can also make it look something like this....

image

@Nodd, @SylvainCorlay?

@Nodd
Copy link
Contributor

Nodd commented Jun 16, 2015

2nd one looks better !

@SylvainCorlay
Copy link
Member

+1 for the second screenshot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants