PR: Fix issue #23497 #23498
Open
PR: Fix issue #23497 #23498
+6
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @Social-Mean! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2025-01-17 11:51:49 UTC |
|
This PR is a supplement to #23444 |
ccordoba12
reviewed
Jan 17, 2025
There was a problem hiding this comment.
@Social-Mean, quick feedback for your about your proposed solution.
Comment on lines
+295
to
+298
| # Avoid conflicts with `--connect-to-kernel` option. See issue #23497 | ||
| # for more information. | ||
| if connection_file is not None: | ||
| return |
There was a problem hiding this comment.
This will prevent opening the project passed through the command line, which would seem like an error to users. So, I don't think this is the right solution.
Instead, I propose to add a method to the IPython console called _handle_connect_to_kernel_cli that would receive connection_file and could be called after open_project below.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Issue(s) Resolved
Fixes #23497
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: @Social-Mean