From 882d6044ab474725999b1289fdd2199d18e63ceb Mon Sep 17 00:00:00 2001
From: dalthviz <d.althviz10@uniandes.edu.co>
Date: Tue, 22 Aug 2023 13:00:07 -0500
Subject: [PATCH 1/4] Improve enum to flags aliasing for PyQt6

---
 qtpy/QtCore.py               | 5 +++--
 qtpy/QtWidgets.py            | 7 +++++--
 qtpy/tests/test_qtcore.py    | 1 +
 qtpy/tests/test_qtwidgets.py | 3 ++-
 4 files changed, 11 insertions(+), 5 deletions(-)

diff --git a/qtpy/QtCore.py b/qtpy/QtCore.py
index 1cf60668..cab4d061 100644
--- a/qtpy/QtCore.py
+++ b/qtpy/QtCore.py
@@ -62,10 +62,11 @@
     # Alias for MiddleButton removed in PyQt6 but available in PyQt5, PySide2 and PySide6
     Qt.MidButton = Qt.MiddleButton
 
-    # Add removed definition for `Qt.ItemFlags` as an alias of `Qt.ItemFlag` as PySide6 does.
+    # Add removed definition for `Qt.ItemFlags` as an alias of `Qt.ItemFlag`
+    # passing as default value 0 in the same way PySide6 does.
     # Note that for PyQt5 and PySide2 those definitions are two different classes
     # (one is the flag definition and the other the enum definition)
-    Qt.ItemFlags = Qt.ItemFlag
+    Qt.ItemFlags = lambda value=0: Qt.ItemFlag(value)
 
 elif PYSIDE2:
     from PySide2.QtCore import *
diff --git a/qtpy/QtWidgets.py b/qtpy/QtWidgets.py
index ebb1d87b..0b4fd154 100644
--- a/qtpy/QtWidgets.py
+++ b/qtpy/QtWidgets.py
@@ -71,8 +71,11 @@ def _directory_to_dir_(*args, **kwargs):
     QMenu.exec_ = lambda *args, **kwargs: possibly_static_exec(QMenu, *args, **kwargs)
     QLineEdit.getTextMargins = lambda self: (self.textMargins().left(), self.textMargins().top(), self.textMargins().right(), self.textMargins().bottom())
 
-    # Map missing flags definitions
-    QFileDialog.Options = QFileDialog.Option
+    # Add removed definition for `QFileDialog.Options` as an alias of `QFileDialog.Option`
+    # passing as default value 0 in the same way PySide6 does.
+    # Note that for PyQt5 and PySide2 those definitions are two different classes
+    # (one is the flag definition and the other the enum definition)
+    QFileDialog.Options = lambda value=0: QFileDialog.Option(value)
 
     # Allow unscoped access for enums inside the QtWidgets module
     from .enums_compat import promote_enums
diff --git a/qtpy/tests/test_qtcore.py b/qtpy/tests/test_qtcore.py
index 20f21cbc..9b68c36d 100644
--- a/qtpy/tests/test_qtcore.py
+++ b/qtpy/tests/test_qtcore.py
@@ -162,3 +162,4 @@ def test_itemflags_typedef():
     Test existence of `QFlags<ItemFlag>` typedef `ItemFlags` that was removed from PyQt6
     """
     assert QtCore.Qt.ItemFlags is not None
+    assert QtCore.Qt.ItemFlags() == QtCore.Qt.ItemFlag(0)
diff --git a/qtpy/tests/test_qtwidgets.py b/qtpy/tests/test_qtwidgets.py
index 203c11b7..5607ccf5 100644
--- a/qtpy/tests/test_qtwidgets.py
+++ b/qtpy/tests/test_qtwidgets.py
@@ -236,4 +236,5 @@ def test_qfiledialog_flags_typedef():
     """
     Test existence of `QFlags<Option>` typedef `Options` that was removed from PyQt6
     """
-    assert QtWidgets.QFileDialog.Options is not None
+    assert QtWidgets.QFileDialog.Options is not None    
+    assert QtWidgets.QFileDialog.Options() == QtWidgets.QFileDialog.Option(0)

From d389b16399fcbfcdacda582b638db82e0ab310ce Mon Sep 17 00:00:00 2001
From: dalthviz <d.althviz10@uniandes.edu.co>
Date: Tue, 22 Aug 2023 13:40:32 -0500
Subject: [PATCH 2/4] Testing

---
 qtpy/QtCore.py    | 10 ++++++++--
 qtpy/QtWidgets.py |  6 +++++-
 2 files changed, 13 insertions(+), 3 deletions(-)

diff --git a/qtpy/QtCore.py b/qtpy/QtCore.py
index cab4d061..ed14b1d3 100644
--- a/qtpy/QtCore.py
+++ b/qtpy/QtCore.py
@@ -9,7 +9,9 @@
 """Provides QtCore classes and functions."""
 from typing import TYPE_CHECKING
 
-from . import PYQT6, PYQT5, PYSIDE2, PYSIDE6
+from packaging.version import parse
+
+from . import PYQT6, PYQT5, PYSIDE2, PYSIDE6, QT_VERSION as _qt_version
 from ._utils import possibly_static_exec, possibly_static_exec_
 
 if PYQT5:
@@ -63,7 +65,7 @@
     Qt.MidButton = Qt.MiddleButton
 
     # Add removed definition for `Qt.ItemFlags` as an alias of `Qt.ItemFlag`
-    # passing as default value 0 in the same way PySide6 does.
+    # passing as default value 0 in the same way PySide6 6.5+ does.
     # Note that for PyQt5 and PySide2 those definitions are two different classes
     # (one is the flag definition and the other the enum definition)
     Qt.ItemFlags = lambda value=0: Qt.ItemFlag(value)
@@ -111,6 +113,10 @@
     QThread.exec_ = lambda self, *args, **kwargs: self.exec(*args, **kwargs)
     QTextStreamManipulator.exec_ = lambda self, *args, **kwargs: self.exec(*args, **kwargs)
 
+    # Passing as default value 0 in the same way PySide6 6.3.2 does for the `Qt.ItemFlags` definition.
+    if parse(_qt_version) > parse('6.3'):
+        Qt.ItemFlags = lambda value=0: Qt.ItemFlag(value)
+
 # For issue #153 and updated for issue #305
 if PYQT5 or PYQT6:
     QDate.toPython = lambda self, *args, **kwargs: self.toPyDate(*args, **kwargs)
diff --git a/qtpy/QtWidgets.py b/qtpy/QtWidgets.py
index 0b4fd154..19d97532 100644
--- a/qtpy/QtWidgets.py
+++ b/qtpy/QtWidgets.py
@@ -72,7 +72,7 @@ def _directory_to_dir_(*args, **kwargs):
     QLineEdit.getTextMargins = lambda self: (self.textMargins().left(), self.textMargins().top(), self.textMargins().right(), self.textMargins().bottom())
 
     # Add removed definition for `QFileDialog.Options` as an alias of `QFileDialog.Option`
-    # passing as default value 0 in the same way PySide6 does.
+    # passing as default value 0 in the same way PySide6 6.5+ does.
     # Note that for PyQt5 and PySide2 those definitions are two different classes
     # (one is the flag definition and the other the enum definition)
     QFileDialog.Options = lambda value=0: QFileDialog.Option(value)
@@ -111,6 +111,10 @@ def _directory_to_dir_(*args, **kwargs):
     QDialog.exec_ = lambda self, *args, **kwargs: self.exec(*args, **kwargs)
     QMenu.exec_ = lambda *args, **kwargs: possibly_static_exec(QMenu, *args, **kwargs)
 
+    # Passing as default value 0 in the same way PySide6 < 6.3.2 does for the `QFileDialog.Options` definition.
+    if parse(_qt_version) > parse('6.3'):
+        QFileDialog.Options = lambda value=0: QFileDialog.Option(value)
+
 
 if PYSIDE2 or PYSIDE6:
     QFileDialog.getExistingDirectory = _directory_to_dir(QFileDialog.getExistingDirectory)

From 78822e3dc1272ed9a965e9d2c9a7a74055c0c2ee Mon Sep 17 00:00:00 2001
From: dalthviz <d.althviz10@uniandes.edu.co>
Date: Wed, 23 Aug 2023 10:23:17 -0500
Subject: [PATCH 3/4] Add missing staticmethod decorator to kwargs renaming
 wrapper function

---
 qtpy/QtWidgets.py | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/qtpy/QtWidgets.py b/qtpy/QtWidgets.py
index 19d97532..24b8b13c 100644
--- a/qtpy/QtWidgets.py
+++ b/qtpy/QtWidgets.py
@@ -24,6 +24,12 @@ def __getattr__(name):
         name, module_name=__name__, optional_names=_missing_optional_names)
 
 def _dir_to_directory(func):
+    """
+    Helper function to manage `dir` to `directory` `QFileDialog` kwargs change.
+
+    Makes PyQt5/6 `QFileDialog` static methods accept the `dir` kwarg.
+    """
+    @staticmethod
     @wraps(func)
     def _dir_to_directory_(*args, **kwargs):
         if "dir" in kwargs:
@@ -32,6 +38,12 @@ def _dir_to_directory_(*args, **kwargs):
     return _dir_to_directory_
 
 def _directory_to_dir(func):
+    """
+    Helper function to manaje `directory` to `dir` `QFileDialog` kwargs change.
+
+    Makes PySide2/6 `QFileDialog` static methods accept the `directory` kwarg.
+    """
+    @staticmethod
     @wraps(func)
     def _directory_to_dir_(*args, **kwargs):
         if "directory" in kwargs:

From 335687d54ee058c321543881a8dcccbd89f25096 Mon Sep 17 00:00:00 2001
From: dalthviz <d.althviz10@uniandes.edu.co>
Date: Wed, 23 Aug 2023 11:26:33 -0500
Subject: [PATCH 4/4] Refactor kwargs wrapper functions and define a general
 static methods kwargs wrapper function in _utils

---
 qtpy/QtWidgets.py | 71 ++++++++++++++++++++++-------------------------
 qtpy/_utils.py    | 16 +++++++++++
 2 files changed, 49 insertions(+), 38 deletions(-)

diff --git a/qtpy/QtWidgets.py b/qtpy/QtWidgets.py
index 24b8b13c..719fa61a 100644
--- a/qtpy/QtWidgets.py
+++ b/qtpy/QtWidgets.py
@@ -7,12 +7,17 @@
 # -----------------------------------------------------------------------------
 
 """Provides widget classes and functions."""
-from functools import partialmethod, wraps
+from functools import partialmethod
 
 from packaging.version import parse
 
 from . import PYQT5, PYQT6, PYSIDE2, PYSIDE6, QT_VERSION as _qt_version
-from ._utils import add_action, possibly_static_exec, getattr_missing_optional_dep
+from ._utils import (
+    add_action,
+    possibly_static_exec,
+    getattr_missing_optional_dep,
+    static_method_kwargs_wrapper
+)
 
 
 _missing_optional_names = {}
@@ -23,34 +28,6 @@ def __getattr__(name):
     raise getattr_missing_optional_dep(
         name, module_name=__name__, optional_names=_missing_optional_names)
 
-def _dir_to_directory(func):
-    """
-    Helper function to manage `dir` to `directory` `QFileDialog` kwargs change.
-
-    Makes PyQt5/6 `QFileDialog` static methods accept the `dir` kwarg.
-    """
-    @staticmethod
-    @wraps(func)
-    def _dir_to_directory_(*args, **kwargs):
-        if "dir" in kwargs:
-            kwargs["directory"] = kwargs.pop("dir")
-        return func(*args, **kwargs)
-    return _dir_to_directory_
-
-def _directory_to_dir(func):
-    """
-    Helper function to manaje `directory` to `dir` `QFileDialog` kwargs change.
-
-    Makes PySide2/6 `QFileDialog` static methods accept the `directory` kwarg.
-    """
-    @staticmethod
-    @wraps(func)
-    def _directory_to_dir_(*args, **kwargs):
-        if "directory" in kwargs:
-            kwargs["dir"] = kwargs.pop("directory")
-        return func(*args, **kwargs)
-    return _directory_to_dir_
-
 
 if PYQT5:
     from PyQt5.QtWidgets import *
@@ -129,15 +106,33 @@ def _directory_to_dir_(*args, **kwargs):
 
 
 if PYSIDE2 or PYSIDE6:
-    QFileDialog.getExistingDirectory = _directory_to_dir(QFileDialog.getExistingDirectory)
-    QFileDialog.getOpenFileName = _directory_to_dir(QFileDialog.getOpenFileName)
-    QFileDialog.getOpenFileNames = _directory_to_dir(QFileDialog.getOpenFileNames)
-    QFileDialog.getSaveFileName = _directory_to_dir(QFileDialog.getSaveFileName)
+    # Make PySide2/6 `QFileDialog` static methods accept the `directory` kwarg as `dir`
+    QFileDialog.getExistingDirectory = static_method_kwargs_wrapper(
+        QFileDialog.getExistingDirectory, "directory", "dir"
+    )
+    QFileDialog.getOpenFileName = static_method_kwargs_wrapper(
+        QFileDialog.getOpenFileName, "directory", "dir"
+    )
+    QFileDialog.getOpenFileNames = static_method_kwargs_wrapper(
+        QFileDialog.getOpenFileNames, "directory", "dir"
+    )
+    QFileDialog.getSaveFileName = static_method_kwargs_wrapper(
+        QFileDialog.getSaveFileName, "directory", "dir"
+    )
 else:
-    QFileDialog.getExistingDirectory = _dir_to_directory(QFileDialog.getExistingDirectory)
-    QFileDialog.getOpenFileName = _dir_to_directory(QFileDialog.getOpenFileName)
-    QFileDialog.getOpenFileNames = _dir_to_directory(QFileDialog.getOpenFileNames)
-    QFileDialog.getSaveFileName = _dir_to_directory(QFileDialog.getSaveFileName)
+    # Make PyQt5/6 `QFileDialog` static methods accept the `dir` kwarg as `directory`
+    QFileDialog.getExistingDirectory = static_method_kwargs_wrapper(
+        QFileDialog.getExistingDirectory, "dir", "directory"
+    )
+    QFileDialog.getOpenFileName = static_method_kwargs_wrapper(
+        QFileDialog.getOpenFileName, "dir", "directory"
+    )
+    QFileDialog.getOpenFileNames = static_method_kwargs_wrapper(
+        QFileDialog.getOpenFileNames, "dir", "directory"
+    )
+    QFileDialog.getSaveFileName = static_method_kwargs_wrapper(
+        QFileDialog.getSaveFileName, "dir", "directory"
+    )
 
 # Make `addAction` compatible with Qt6 >= 6.3
 if PYQT5 or PYSIDE2 or parse(_qt_version) < parse('6.3'):
diff --git a/qtpy/_utils.py b/qtpy/_utils.py
index 4dce8bb0..fdf59b46 100644
--- a/qtpy/_utils.py
+++ b/qtpy/_utils.py
@@ -6,6 +6,7 @@
 # -----------------------------------------------------------------------------
 
 """Provides utility functions for use by QtPy itself."""
+from functools import wraps
 
 import qtpy
 
@@ -112,3 +113,18 @@ def add_action(self, *args, old_add_action):
             return old_add_action(self, *args)
         return action
     return old_add_action(self, *args)
+
+
+def static_method_kwargs_wrapper(func, from_kwarg_name, to_kwarg_name):
+    """
+    Helper function to manage `from_kwarg_name` to `to_kwarg_name` kwargs name changes in static methods.
+
+    Makes static methods accept the `from_kwarg_name` kwarg as `to_kwarg_name`.
+    """
+    @staticmethod
+    @wraps(func)
+    def _from_kwarg_name_to_kwarg_name_(*args, **kwargs):
+        if from_kwarg_name in kwargs:
+            kwargs[to_kwarg_name] = kwargs.pop(from_kwarg_name)
+        return func(*args, **kwargs)
+    return _from_kwarg_name_to_kwarg_name_