Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make docker images public #30

Closed
mpetrun5 opened this issue Oct 27, 2022 · 5 comments
Closed

Make docker images public #30

mpetrun5 opened this issue Oct 27, 2022 · 5 comments
Assignees

Comments

@mpetrun5
Copy link
Collaborator

mpetrun5 commented Oct 27, 2022

For relaying partners to be able to run their own relayers we should make the docker images built on release public.

Implementation details

Switch to dockerhub and make them public there.

Testing details

Acceptance Criteria

@mpetrun5
Copy link
Collaborator Author

@rbadillap Do you have time to handle this?

@P1sar
Copy link
Contributor

P1sar commented Oct 27, 2022

Can't we use github docker registry for this?

@mpetrun5
Copy link
Collaborator Author

mpetrun5 commented Oct 27, 2022

We could. For open-source projects both are free. I think it is just a habit for open-source projects to use Dockerhub because of discoverability, but we don't care too much about that so it is fine either way. AWS as well should have a way to make it public.

@MakMuftic
Copy link
Contributor

We also need this so we can use it in example repository.

@rbadillap
Copy link
Contributor

@eedygreen, to accomplish this task, we should change the GitHub workflows and ECS task definitions to point to GitHub Docker Registry instead of AWS ECR.

AWS offers the possibility to make public our docker images using the AWS Public Gallery; you can discuss with the team if this is feasible or if they prefer using GitHub for that.

In both cases, the ECS task definition and the workflows should be adapted to this new way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants