You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is causing issues with my build using browserify: Cannot find module 'React' from [...]/node_modules/react-svg-icon/dist', and as a consequence the bundle contains React twice (under React and react), increasing the minified size by 20kb.
I think that a simple fix for this might be to change the package.json's main to build/lib/index.js (and commit that folder) so that we export the CommonJS build instead of the UMD one.
There's weirdness in the exported bundle because of
rackt-cli
's Webpack configuration (React package name):https://github.com/springload/react-svg-icon/blob/master/dist/react-svg-icon.js#L3
This is causing issues with my build using browserify:
Cannot find module 'React' from [...]/node_modules/react-svg-icon/dist'
, and as a consequence the bundle contains React twice (underReact
andreact
), increasing the minified size by 20kb.It's because of mzabriskie/rackt-cli#18. What should we do to fix this?
The text was updated successfully, but these errors were encountered: