Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

completion for @DependsOn should not suggest its own bean #1429

Closed
martinlippert opened this issue Dec 3, 2024 · 1 comment
Closed

completion for @DependsOn should not suggest its own bean #1429

martinlippert opened this issue Dec 3, 2024 · 1 comment
Assignees
Labels
for: eclipse something that is specific for Eclipse for: vscode something that is specific for VSCode theme: code completion type: enhancement

Comments

@martinlippert
Copy link
Member

At the moment, code completion for @DependsOn suggests all the bean names of the project, but it should not suggest the name of the bean on which the annotation itself is declared on. Does not make a lot of sense to declare a dependency on its own.

@Component
@DependsOn(<*>)
public class MovieService {
...

Proposals in this case should not include the movieService bean name.

@martinlippert martinlippert added type: enhancement for: eclipse something that is specific for Eclipse for: vscode something that is specific for VSCode theme: code completion labels Dec 3, 2024
@martinlippert martinlippert added this to the 4.28.0.RELEASE milestone Dec 3, 2024
@martinlippert martinlippert self-assigned this Dec 3, 2024
@martinlippert
Copy link
Member Author

Looks like this does work for

@DependsOn(<*>)

but not for

@DependsOn("<*>")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
for: eclipse something that is specific for Eclipse for: vscode something that is specific for VSCode theme: code completion type: enhancement
Projects
None yet
Development

No branches or pull requests

1 participant