GH-427: Add fix for the issue with multiplierExpression and randomExp… #428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n and randomExpressions
artembilan
requested changes
Apr 29, 2024
Member
artembilan
left a comment
artembilan
left a comment
There was a problem hiding this comment.
Thank you for the contribution!
Let me know if my review makes sense for you!
...ain/java/org/springframework/retry/annotation/AnnotationAwareRetryOperationsInterceptor.java
Show resolved
Hide resolved
src/main/java/org/springframework/retry/backoff/BackOffPolicyBuilder.java
Show resolved
Hide resolved
artembilan
requested changes
May 3, 2024
...ain/java/org/springframework/retry/annotation/AnnotationAwareRetryOperationsInterceptor.java
Outdated
Show resolved
Hide resolved
src/main/java/org/springframework/retry/annotation/Backoff.java
Outdated
Show resolved
Hide resolved
src/main/java/org/springframework/retry/backoff/ExponentialBackOffPolicy.java
Outdated
Show resolved
Hide resolved
…tween 0 to 1" This reverts commit 7c478d1.
artembilan
requested changes
May 6, 2024
...ain/java/org/springframework/retry/annotation/AnnotationAwareRetryOperationsInterceptor.java
Outdated
Show resolved
Hide resolved
artembilan
requested changes
May 9, 2024
src/test/java/org/springframework/retry/backoff/BackOffPolicyBuilderTests.java
Outdated
Show resolved
Hide resolved
src/test/java/org/springframework/retry/backoff/BackOffPolicyBuilderTests.java
Outdated
Show resolved
Hide resolved
artembilan
requested changes
May 10, 2024
Member
artembilan
left a comment
artembilan
left a comment
There was a problem hiding this comment.
Just a couple minor nit-pick to make the code in the test more cleaner.
Thanks
src/test/java/org/springframework/retry/backoff/BackOffPolicyBuilderTests.java
Outdated
Show resolved
Hide resolved
src/test/java/org/springframework/retry/backoff/BackOffPolicyBuilderTests.java
Show resolved
Hide resolved
artembilan
requested changes
May 10, 2024
Member
artembilan
left a comment
artembilan
left a comment
There was a problem hiding this comment.
The build has failed:
Error: Failed to execute goal io.spring.javaformat:spring-javaformat-maven-plugin:0.0.40:validate (default) on project spring-retry: Formatting violations found in the following files:
Error: * /home/runner/work/spring-retry/spring-retry/src/main/java/org/springframework/retry/annotation/Backoff.java
Error: * /home/runner/work/spring-retry/spring-retry/src/test/java/org/springframework/retry/backoff/BackOffPolicyBuilderTests.java
Error:
Error: Run `spring-javaformat:apply` to fix.
When you fix that and build is green, I'll merge.
Thanks
Member
|
Has been merged. Thank you for contribution; looking forward for more! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue explained here: Issue number 427.
Please comment if there is any feedback.