Documentation for the SMB Adapter Module #3793
Conversation
artembilan
left a comment
artembilan
left a comment
There was a problem hiding this comment.
Please, also consider to rebase your branch to the latest main: I've just added a fix for GH actions where I missed a distribution option for setup-java.
Hopefully I did it right this time... I won't know until I commit the changes I guess. |
You just need to |
GregBragg
force-pushed
the
Create_Documentation_For_SMB_Module
branch
from
63f413d to
35cd16a
Compare
Yeah I did it wrong the first time, looks good now... Like I said before this is something in Git that we don't normally do at my employ so I am rusty in that regard. |
artembilan
left a comment
artembilan
left a comment
There was a problem hiding this comment.
Looks good so far: I can fix those minor concerns on merge if you'd prefer.
| === SMB Outbound Channel Adapter | ||
|
|
||
| For writing files to a SMB share, and for XML `<int-smb:outbound-channel-adapter>` component we use the `SmbMessageHandler`. | ||
| In case of Java configuration a `SmbMessageHandler` should be supplied with the `SmbSessionFactory` (or `SmbRemoteFileTemplate`). |
There was a problem hiding this comment.
I think we have reinstate then a ctor in the SmbMessageHandler based on the SmbRemoteFileTemplate, like we have in other FileTransferringMessageHandler impls.
There was a problem hiding this comment.
Agreed... do you want to take this on?
| For writing files to a SMB share, and for XML `<int-smb:outbound-channel-adapter>` component we use the `SmbMessageHandler`. | ||
| In case of Java configuration a `SmbMessageHandler` should be supplied with the `SmbSessionFactory` (or `SmbRemoteFileTemplate`). | ||
|
|
||
| [source,java] |
There was a problem hiding this comment.
If you wish, there is a way to have the same sample in different modes: XML, Java, Kotlin.
You can find a sample in the amqp.adoc.
There was a problem hiding this comment.
I'll need to investigate this... I'm more used to using the Java Bean configuration approach.
artembilan
left a comment
artembilan
left a comment
There was a problem hiding this comment.
LGTM.
Pulling locally for final clean up and merge.
|
Merged as b64e379 after some clean up. I also added thank you again for contribution. Now it is time to look into Java DSL for this module. 😄 |
|
Thanks @artembilan !!! Much appreciated... |
Looking into this now, however it will be awhile as I am juggling other priorities at work... stay tuned. |
2 participants
@artembilan as discussed here is my first crack at creating documentation in AsciiDoc format for the SMB Adapter module.
Thanks!