AbstractMessageListenerContainer.refreshSharedConnection [SPR-3059]

[spring-projects-issues]

Alfons Spiegelhauer opened SPR-3059 and commented

Method AbstractMessageListenerContainer.refreshSharedConnection

After line
ConnectionFactoryUtils.releaseConnection(this.sharedConnection, getConnectionFactory(), running);

this.sharedConnection should be set to null.
After the call to ConnectionFactoryUtils.releaseConnection the connection is logically closed

protected final void refreshSharedConnection() throws JMSException {
	boolean running = isRunning();
	synchronized (this.sharedConnectionMonitor) {
		ConnectionFactoryUtils.releaseConnection(this.sharedConnection, getConnectionFactory(), running);

this.sharedConnection = null;

		Connection con = createConnection();
		try {
			prepareSharedConnection(con);
		}
		catch (JMSException ex) {
			JmsUtils.closeConnection(con);
			throw ex;
		}
		this.sharedConnection = con;
	}
}

---

Affects: 2.0.2

[spring-projects-issues]

Juergen Hoeller commented

Thanks for spotting this! Indeed, in particular for the exception case, we need to reset the "sharedConnection" variable there.

Juergen