@Cacheable does not respect cache hit when empty Mono/Flux response is returned

[fabioacsilva]

Hello,

Upon upgrading to spring-boot 3.2.0 and Java 21 our team noticed that our methods annotated with @Cacheable do not cache properly when the return is an empty Flux.

Sample source code provided:
cacheable.zip

Using the past example if we hit the endpoint with anything other than "broken" we get the following log:

2023-12-19T13:41:26.592Z  INFO 50082 --- [           main] c.e.cacheable.CacheableApplicationKt     : Started CacheableApplicationKt in 0.809 seconds (process running for 1.124)
2023-12-19T13:41:30.216Z  INFO 50082 --- [ctor-http-nio-2] com.example.cacheable.Controller         : Controller - id:hello
2023-12-19T13:41:30.217Z TRACE 50082 --- [ctor-http-nio-2] o.s.cache.interceptor.CacheInterceptor   : Computed cache key 'hello' for operation Builder[public reactor.core.publisher.Flux com.example.cacheable.Service.get(java.lang.String)] caches=[myCache] | key='' | keyGenerator='' | cacheManager='' | cacheResolver='' | condition='' | unless='' | sync='false'
2023-12-19T13:41:30.217Z TRACE 50082 --- [ctor-http-nio-2] o.s.cache.interceptor.CacheInterceptor   : No cache entry for key 'hello' in cache(s) [myCache]
2023-12-19T13:41:30.218Z  INFO 50082 --- [ctor-http-nio-2] org.springframework.stereotype.Service   : Service - id:hello
2023-12-19T13:41:30.219Z TRACE 50082 --- [ctor-http-nio-2] o.s.cache.interceptor.CacheInterceptor   : Computed cache key 'hello' for operation Builder[public reactor.core.publisher.Flux com.example.cacheable.Service.get(java.lang.String)] caches=[myCache] | key='' | keyGenerator='' | cacheManager='' | cacheResolver='' | condition='' | unless='' | sync='false'
2023-12-19T13:41:30.219Z TRACE 50082 --- [ctor-http-nio-2] o.s.cache.interceptor.CacheInterceptor   : Creating cache entry for key 'hello' in cache(s) [myCache]
2023-12-19T13:41:32.744Z  INFO 50082 --- [ctor-http-nio-2] com.example.cacheable.Controller         : Controller - id:hello
2023-12-19T13:41:32.745Z TRACE 50082 --- [ctor-http-nio-2] o.s.cache.interceptor.CacheInterceptor   : Computed cache key 'hello' for operation Builder[public reactor.core.publisher.Flux com.example.cacheable.Service.get(java.lang.String)] caches=[myCache] | key='' | keyGenerator='' | cacheManager='' | cacheResolver='' | condition='' | unless='' | sync='false'
2023-12-19T13:41:32.757Z TRACE 50082 --- [ctor-http-nio-2] o.s.cache.interceptor.CacheInterceptor   : Cache entry for key 'hello' found in cache(s) 

As we can see the service log is only called once due to the cache.

If we call it with "broken" we get the following log:

2023-12-19T13:41:48.729Z  INFO 50082 --- [ctor-http-nio-2] com.example.cacheable.Controller         : Controller - id:broken
2023-12-19T13:41:48.730Z TRACE 50082 --- [ctor-http-nio-2] o.s.cache.interceptor.CacheInterceptor   : Computed cache key 'broken' for operation Builder[public reactor.core.publisher.Flux com.example.cacheable.Service.get(java.lang.String)] caches=[myCache] | key='' | keyGenerator='' | cacheManager='' | cacheResolver='' | condition='' | unless='' | sync='false'
2023-12-19T13:41:48.730Z TRACE 50082 --- [ctor-http-nio-2] o.s.cache.interceptor.CacheInterceptor   : No cache entry for key 'broken' in cache(s) [myCache]
2023-12-19T13:41:48.730Z  INFO 50082 --- [ctor-http-nio-2] org.springframework.stereotype.Service   : Service - id:broken
2023-12-19T13:41:48.731Z TRACE 50082 --- [ctor-http-nio-2] o.s.cache.interceptor.CacheInterceptor   : Computed cache key 'broken' for operation Builder[public reactor.core.publisher.Flux com.example.cacheable.Service.get(java.lang.String)] caches=[myCache] | key='' | keyGenerator='' | cacheManager='' | cacheResolver='' | condition='' | unless='' | sync='false'
2023-12-19T13:41:48.731Z TRACE 50082 --- [ctor-http-nio-2] o.s.cache.interceptor.CacheInterceptor   : Creating cache entry for key 'broken' in cache(s) [myCache]
2023-12-19T13:41:51.560Z  INFO 50082 --- [ctor-http-nio-2] com.example.cacheable.Controller         : Controller - id:broken
2023-12-19T13:41:51.561Z TRACE 50082 --- [ctor-http-nio-2] o.s.cache.interceptor.CacheInterceptor   : Computed cache key 'broken' for operation Builder[public reactor.core.publisher.Flux com.example.cacheable.Service.get(java.lang.String)] caches=[myCache] | key='' | keyGenerator='' | cacheManager='' | cacheResolver='' | condition='' | unless='' | sync='false'
2023-12-19T13:41:51.561Z TRACE 50082 --- [ctor-http-nio-2] o.s.cache.interceptor.CacheInterceptor   : Cache entry for key 'broken' found in cache(s) [myCache]
2023-12-19T13:41:51.564Z  INFO 50082 --- [ctor-http-nio-2] org.springframework.stereotype.Service   : Service - id:broken
2023-12-19T13:41:51.565Z TRACE 50082 --- [ctor-http-nio-2] o.s.cache.interceptor.CacheInterceptor   : Computed cache key 'broken' for operation Builder[public reactor.core.publisher.Flux com.example.cacheable.Service.get(java.lang.String)] caches=[myCache] | key='' | keyGenerator='' | cacheManager='' | cacheResolver='' | condition='' | unless='' | sync='false'
2023-12-19T13:41:51.565Z TRACE 50082 --- [ctor-http-nio-2] o.s.cache.interceptor.CacheInterceptor   : Creating cache entry for key 'broken' in cache(s) [myCache]

The service keeps getting called meaning the cache is not working properly.

If we revert to spring-boot 3.1.6 and Java 17 the behaviour is the one expected and the empty flux gets cached

[snicoll]

@Cacheable do not cache properly when the return is an empty Flux.

Spring Framework 6.1 has explicit support for reactive types (which wasn't really supported before). See #17920

[fabioacsilva]

But caching is working for everything except when the response is an empty flux, which was working in spring-boot 3.1.6

[jhoeller]

We mean to cache an empty list in such a case, and we do put that cache entry, but then we reinvoke the method in case of a cache hit with an empty publisher (which our unit test did not catch since it was only checking the cache entry itself).

To be fixed for 6.1.3.

[jhoeller]

As a side note: @fabioacsilva so you were actually caching Flux instances before? Using Flux.cache() possibly? This wasn't meant to be used like that before since Mono/Flux instances are generally hot handles - but nevertheless this seems to have worked for some scenarios.

In any case, as of 6.1, we attach to the reactive pipeline in order to cache the produced value (a list of values in case of a Flux), so not storing the actual reactive handle in the cache but rather the value that it produces.

[fabioacsilva]

@jhoeller We were caching Flux instances with @Cacheable and Flux.cache(), example code:

    @Cacheable(value = ["myCache"])
    @CircuitBreaker(name = MY_CIRCUIT_BREAKER)
    internal fun get(myParam: String): Flux<MyModel> =
        webClient
            .get()
            .uri { it.path(MY_URI).build(myParam) }
            .retrieve()
            .bodyToFlux(MyModel::class.java)
            .cache(myConfiguration.updateInterval)

We had some unit tests with a bunch of values and caught the empty list one with them. Thank you for your response

[jhoeller]

This should be fixed in the upcoming 6.1.3 snapshot through an earlier switchIfEmpty check right after cache miss determination now, rather then the late check we had after a cache hit as well.

It would be great if you could give such a snapshot a try from repo.spring.io before we actually release 6.1.3 in early January.