Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TOC generated by asciidoc for core-beans.adoc is truncated #24132

Closed
Farteen opened this issue Dec 4, 2019 · 3 comments
Closed

TOC generated by asciidoc for core-beans.adoc is truncated #24132

Farteen opened this issue Dec 4, 2019 · 3 comments
Assignees
Labels
type: documentation A documentation task
Milestone

Comments

@Farteen
Copy link

Farteen commented Dec 4, 2019

Affects: 5.2.2.RELEASE

This is a trivial issue with table of contents which are generated by asciidoc. Look at the picture
I uploaded some tocs were missing. Last three days I had been reading the spring-framework-reference with previous RELEASE(maybe 5.1.9RELEASE). When I open the newest reference website, the missing happened.
11575470056_ pic_hd

I've been comparing the diff between previous RELEASE and 5.2.2 RELEASE, something wrong in
core/core-beans.adoc
21575471072_ pic_hd

After I delete the four equal marks which stand for Level 3 Section in asciidoc, and execute
./gradlew asciidoctor
the reference generated in my computer has the complete tocs.
31575471652_ pic_hd

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Dec 4, 2019
@rstoyanchev rstoyanchev self-assigned this Dec 4, 2019
@rstoyanchev rstoyanchev added type: task A general task and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Dec 4, 2019
@rstoyanchev rstoyanchev added this to the 5.2.3 milestone Dec 4, 2019
@rstoyanchev rstoyanchev changed the title some toc generated by asciidoc are missing TOC generated by asciidoc for core-beans.adoc is truncated Dec 4, 2019
@spring-projects-issues spring-projects-issues added status: backported An issue that has been backported to maintenance branches and removed for: backport-to-5.1.x labels Dec 4, 2019
@rstoyanchev rstoyanchev removed the status: backported An issue that has been backported to maintenance branches label Dec 4, 2019
@rstoyanchev
Copy link
Contributor

rstoyanchev commented Dec 4, 2019

It looks like there was a mismatched ==== at the end of a code sample and then an unbalanced [NOTE] a couple of paragraphs below, which made both go unnoticed for a while. Then a recent change in 55011e7 fixed the [NOTE] which then exposed the other unbalanced marker.

@sbrannen
Copy link
Member

sbrannen commented Dec 6, 2019

I'm reopening this since the latest build snapshots display improper headings.

https://docs.spring.io/spring/docs/5.2.2.BUILD-SNAPSHOT/spring-framework-reference/core.html#beans-java-bean-annotation

@sbrannen sbrannen reopened this Dec 6, 2019
@sbrannen sbrannen added type: documentation A documentation task and removed type: task A general task labels Dec 6, 2019
@sbrannen
Copy link
Member

sbrannen commented Dec 6, 2019

Oops. That was a typo on my part. It's actually fixed in the 5.2.3 snapshot:

https://docs.spring.io/spring/docs/5.2.3.BUILD-SNAPSHOT/spring-framework-reference/core.html#beans-autowired-annotation-qualifiers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation A documentation task
Projects
None yet
Development

No branches or pull requests

4 participants