AntPathMatcher#isPattern ignores template variables

[rstoyanchev]

Currently it checks the presence of "*" and "?" only.

[rstoyanchev]

The change in isPattern causes at least one test to fail where the path has property placeholders such as ${foo}. Not sure if it is anything that can happen in practice, but I would imagine it can.

I suppose I could make the checks for { in spring-messaging and spring-web but AntPathMatcher does support template variables and is otherwise unaware of placeholders. I checked passing a String with placeholders into the match method. It allows any text in the placeholder as expected but insists on a $ before it, which isn't particularly useful.

I think we should add the { check in isPattern still but protect it with an extra check to see if the character before it is $ or # which would imply a placeholder, and not a pattern wildcard syntax. That way isPattern can report template variable pattern syntax, but also ignore potential placeholders.

@jhoeller I'd be interested in your thoughts based on the usages of isPattern in spring-core.

[rstoyanchev]

The failing test is in ResourceArrayPropertyEditorTests#testSystemPropertyReplacement.