Avoid filtering if selector header is not in use

Author: rstoyanchev

spring-messaging/src/main/java/org/springframework/messaging/simp/broker/AbstractSubscriptionRegistry.java

@@ -23,6 +23,8 @@
 import org.springframework.messaging.MessageHeaders;
 import org.springframework.messaging.simp.SimpMessageHeaderAccessor;
 import org.springframework.messaging.simp.SimpMessageType;
+import org.springframework.util.CollectionUtils;
+import org.springframework.util.LinkedMultiValueMap;
 import org.springframework.util.MultiValueMap;
 
 /**
@@ -35,6 +37,10 @@
  */
 public abstract class AbstractSubscriptionRegistry implements SubscriptionRegistry {
 
+	private static MultiValueMap<String, String> EMPTY_MAP =
+			CollectionUtils.unmodifiableMultiValueMap(new LinkedMultiValueMap<String, String>(0));
+
+
 	protected final Log logger = LogFactory.getLog(getClass());
 
 
@@ -104,7 +110,7 @@ public final MultiValueMap<String, String> findSubscriptions(Message<?> message)
 		String destination = SimpMessageHeaderAccessor.getDestination(headers);
 		if (destination == null) {
 			logger.error("No destination in " + message);
-			return null;
+			return EMPTY_MAP;
 		}
 
 		return findSubscriptionsInternal(destination, message);

spring-messaging/src/main/java/org/springframework/messaging/simp/broker/DefaultSubscriptionRegistry.java

@@ -72,7 +72,9 @@ public class DefaultSubscriptionRegistry extends AbstractSubscriptionRegistry {
 
 	private String selectorHeaderName = "selector";
 
-	private ExpressionParser expressionParser = new SpelExpressionParser();
+	private volatile boolean selectorHeaderInUse = false;
+
+	private final ExpressionParser expressionParser = new SpelExpressionParser();
 
 	private final DestinationCache destinationCache = new DestinationCache();
 
@@ -143,6 +145,7 @@ protected void addSubscriptionInternal(String sessionId, String subsId, String d
 		if (selector != null) {
 			try {
 				expression = this.expressionParser.parseExpression(selector);
+				this.selectorHeaderInUse = true;
 				if (logger.isTraceEnabled()) {
 					logger.trace("Subscription selector: [" + selector + "]");
 				}
@@ -185,6 +188,9 @@ protected MultiValueMap<String, String> findSubscriptionsInternal(String destina
 	private MultiValueMap<String, String> filterSubscriptions(
 			MultiValueMap<String, String> allMatches, Message<?> message) {
 
+		if (!this.selectorHeaderInUse) {
+			return allMatches;
+		}
 		EvaluationContext context = null;
 		MultiValueMap<String, String> result = new LinkedMultiValueMap<String, String>(allMatches.size());
 		for (String sessionId : allMatches.keySet()) {