refined logging in JMS SingleConnectionFactory and DefaultMessageListenerContainer

Author: jhoeller

org.springframework.jms/src/main/java/org/springframework/jms/connection/SingleConnectionFactory.java

@@ -234,7 +234,7 @@ public Connection createConnection(String username, String password) throws JMSE
 	}
 
 	public QueueConnection createQueueConnection() throws JMSException {
-		Connection con = null;
+		Connection con;
 		synchronized (this.connectionMonitor) {
 			this.pubSubMode = Boolean.FALSE;
 			con = createConnection();
@@ -252,7 +252,7 @@ public QueueConnection createQueueConnection(String username, String password) t
 	}
 
 	public TopicConnection createTopicConnection() throws JMSException {
-		Connection con = null;
+		Connection con;
 		synchronized (this.connectionMonitor) {
 			this.pubSubMode = Boolean.TRUE;
 			con = createConnection();
@@ -298,6 +298,7 @@ public void initConnection() throws JMSException {
 	 * Exception listener callback that renews the underlying single Connection.
 	 */
 	public void onException(JMSException ex) {
+		logger.warn("Encountered a JMSException - resetting the underlying JMS Connection", ex);
 		resetConnection();
 	}
 

org.springframework.jms/src/main/java/org/springframework/jms/listener/DefaultMessageListenerContainer.java

@@ -738,10 +738,10 @@ protected void handleListenerSetupFailure(Throwable ex, boolean alreadyRecovered
 				msg.append(getDestinationDescription()).append("' - trying to recover. Cause: ");
 				msg.append(ex instanceof JMSException ? JmsUtils.buildExceptionMessage((JMSException) ex) : ex.getMessage());
 				if (logger.isDebugEnabled()) {
-					logger.info(msg, ex);
+					logger.warn(msg, ex);
 				}
 				else {
-					logger.info(msg);
+					logger.warn(msg);
 				}
 			}
 		}
@@ -792,10 +792,10 @@ protected void refreshConnectionUntilSuccessful() {
 				msg.append(this.recoveryInterval).append(" ms. Cause: ");
 				msg.append(ex instanceof JMSException ? JmsUtils.buildExceptionMessage((JMSException) ex) : ex.getMessage());
 				if (logger.isDebugEnabled()) {
-					logger.info(msg, ex);
+					logger.warn(msg, ex);
 				}
-				else if (logger.isInfoEnabled()) {
-					logger.info(msg);
+				else {
+					logger.warn(msg);
 				}
 			}
 			sleepInbetweenRecoveryAttempts();