fix ignored exceptions

Signed-off-by: Vincent Potucek <[email protected]>

Author: Vincent Potucek

integration-tests/src/test/java/org/springframework/aop/framework/autoproxy/AdvisorAutoProxyCreatorIntegrationTests.java

@@ -158,8 +158,7 @@ void testRollbackRulesOnMethodPreventRollback() throws Exception {
 		try {
 			rb.echoException(new ServletException());
 		}
-		catch (ServletException ex) {
-
+		catch (ServletException ignored) {
 		}
 		assertThat(txMan.commits).as("Transaction counts match").isEqualTo(1);
 	}
@@ -272,9 +271,7 @@ public void before(Method method, Object[] args, Object target) throws Throwable
 					TransactionInterceptor.currentTransactionStatus();
 					throw new RuntimeException("Shouldn't have a transaction");
 				}
-				catch (NoTransactionException ex) {
-					// this is Ok
-				}
+				catch (NoTransactionException ignored) { } // this is Ok
 			}
 			super.before(method, args, target);
 		}

spring-aop/src/main/java/org/springframework/aop/aspectj/AspectJExpressionPointcut.java

@@ -453,10 +453,9 @@ private ShadowMatch getTargetShadowMatch(Method method, Class<?> targetClass) {
 							ClassUtils.toClassArray(ifcs), targetClass.getClassLoader());
 					targetMethod = ClassUtils.getMostSpecificMethod(targetMethod, compositeInterface);
 				}
-				catch (IllegalArgumentException ex) {
-					// Implemented interfaces probably expose conflicting method signatures...
-					// Proceed with original target method.
-				}
+				catch (IllegalArgumentException ignored) { }
+				// Implemented interfaces probably expose conflicting method signatures...
+				// Proceed with original target method.
 			}
 		}
 		return getShadowMatch(targetMethod, method);
@@ -478,7 +477,7 @@ private ShadowMatch getShadowMatch(Method targetMethod, Method originalMethod) {
 					try {
 						shadowMatch = pointcutExpression.matchesMethodExecution(methodToMatch);
 					}
-					catch (ReflectionWorldException ex) {
+					catch (ReflectionWorldException ignored) {
 						// Failed to introspect target method, probably because it has been loaded
 						// in a special ClassLoader. Let's try the declaring ClassLoader instead...
 						try {
@@ -501,7 +500,7 @@ private ShadowMatch getShadowMatch(Method targetMethod, Method originalMethod) {
 						try {
 							shadowMatch = pointcutExpression.matchesMethodExecution(methodToMatch);
 						}
-						catch (ReflectionWorldException ex) {
+						catch (ReflectionWorldException ignored) {
 							// Could neither introspect the target class nor the proxy class ->
 							// let's try the original method's declaring class before we give up...
 							try {

spring-context/src/test/java/org/springframework/aop/framework/AbstractAopProxyTests.java

@@ -233,8 +233,7 @@ void serializableTargetAndAdvice() throws Throwable {
 		try {
 			p2.echo(new IOException());
 		}
-		catch (IOException ex) {
-
+		catch (IOException ignored) {
 		}
 		assertThat(cta.getCalls()).isEqualTo(2);
 	}

spring-core/src/main/java/org/springframework/util/FileCopyUtils.java

@@ -229,8 +229,7 @@ private static void close(Closeable closeable) {
 		try {
 			closeable.close();
 		}
-		catch (IOException ex) {
-			// ignore
+		catch (IOException ignored) {
 		}
 	}
 

spring-test/src/main/java/org/springframework/mock/http/client/MockClientHttpResponse.java

@@ -100,8 +100,7 @@ public void close() {
 		try {
 			getBody().close();
 		}
-		catch (IOException ex) {
-			// ignore
+		catch (IOException ignored) {
 		}
 	}
 

spring-web/src/main/java/org/springframework/http/client/HttpComponentsClientHttpResponse.java

@@ -89,8 +89,7 @@ public void close() {
 				this.httpResponse.close();
 			}
 		}
-		catch (IOException ex) {
-			// Ignore exception on close...
+		catch (IOException ignored) {
 		}
 	}
 

spring-web/src/main/java/org/springframework/http/client/ReactorClientHttpResponse.java

@@ -108,8 +108,7 @@ public void close() {
 			StreamUtils.drain(body);
 			body.close();
 		}
-		catch (IOException ex) {
-			// ignore
+		catch (IOException ignored) {
 		}
 	}
 

spring-web/src/main/java/org/springframework/http/converter/ResourceHttpMessageConverter.java

@@ -158,21 +158,15 @@ protected void writeContent(Resource resource, HttpOutputMessage outputMessage)
 				in.transferTo(out);
 				out.flush();
 			}
-			catch (NullPointerException ex) {
-				// ignore, see SPR-13620
-			}
+			catch (NullPointerException ignored) { } // ignore, see SPR-13620
 			finally {
 				try {
 					in.close();
 				}
-				catch (Throwable ex) {
-					// ignore, see SPR-12999
-				}
+				catch (Throwable ignored) { } // ignore, see SPR-12999
 			}
 		}
-		catch (FileNotFoundException ex) {
-			// ignore, see SPR-12999
-		}
+		catch (FileNotFoundException ignored) { } // ignore, see SPR-12999
 	}
 
 }

spring-web/src/main/java/org/springframework/http/converter/ResourceRegionHttpMessageConverter.java

@@ -183,9 +183,7 @@ protected void writeResourceRegion(ResourceRegion region, HttpOutputMessage outp
 			try {
 				in.close();
 			}
-			catch (IOException ex) {
-				// ignore
-			}
+			catch (IOException ignored) { }
 		}
 	}
 

spring-web/src/main/java/org/springframework/web/client/HttpMessageConverterExtractor.java

@@ -152,8 +152,7 @@ private static byte[] getResponseBody(ClientHttpResponse response) {
 		try {
 			return FileCopyUtils.copyToByteArray(response.getBody());
 		}
-		catch (IOException ex) {
-			// ignore
+		catch (IOException ignored) {
 		}
 		return new byte[0];
 	}