Skip to content

Commit 0b8554f

Browse files
committed
Leave query un-encoded in MockMvc request builder
Issue: SPR-12880
1 parent 6f5359e commit 0b8554f

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

spring-test/src/main/java/org/springframework/test/web/servlet/request/MockHttpServletRequestBuilder.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -581,8 +581,7 @@ public final MockHttpServletRequest buildRequest(ServletContext servletContext)
581581

582582
try {
583583
if (this.uriComponents.getQuery() != null) {
584-
String query = UriUtils.decode(this.uriComponents.getQuery(), "UTF-8");
585-
request.setQueryString(query);
584+
request.setQueryString(this.uriComponents.getQuery());
586585
}
587586

588587
for (Entry<String, List<String>> entry : this.uriComponents.getQueryParams().entrySet()) {

spring-test/src/test/java/org/springframework/test/web/servlet/request/MockHttpServletRequestBuilderTests.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -210,7 +210,7 @@ public void requestParameterFromQueryList() {
210210

211211
MockHttpServletRequest request = this.builder.buildRequest(this.servletContext);
212212

213-
assertEquals("foo[0]=bar&foo[1]=baz", request.getQueryString());
213+
assertEquals("foo%5B0%5D=bar&foo%5B1%5D=baz", request.getQueryString());
214214
assertEquals("bar", request.getParameter("foo[0]"));
215215
assertEquals("baz", request.getParameter("foo[1]"));
216216
}
@@ -221,7 +221,7 @@ public void requestParameterFromQueryWithEncoding() {
221221

222222
MockHttpServletRequest request = this.builder.buildRequest(this.servletContext);
223223

224-
assertEquals("foo=bar=baz", request.getQueryString());
224+
assertEquals("foo=bar%3Dbaz", request.getQueryString());
225225
assertEquals("bar=baz", request.getParameter("foo"));
226226
}
227227

0 commit comments

Comments
 (0)