DATAJDBC-341 - Map NULL values in EntityRowMapper for columns not being fetched in the query #170
Conversation
schauder
changed the title
schauder
changed the title
schauder
left a comment
schauder
left a comment
There was a problem hiding this comment.
when running all the tests I get tons of NPE. I didn't even check why. Those obviously have to go.
The general direction looks good.
| * @author Mark Paluch | ||
| * @author Jens Schauder | ||
| * @author Christoph Strobl | ||
| * @since 1.1 |
There was a problem hiding this comment.
Please make sure to use a formatter so that formatting and ordering of annotation/imports does not get changed.
| propertyAccessor.setProperty(property, readOrLoadProperty(idValue, property)); | ||
| } | ||
| } catch (SQLException e) { | ||
| e.printStackTrace(); |
There was a problem hiding this comment.
Never ever print directly to console. Always use proper logging, with a meaningful message.
In general Exceptions shouldn't get ignored. In the rare cases where this is actually what we want pleas add a comment, why this is the right thing to do.
| value = getObjectFromResultSet(path.extendBy(property).getColumnAlias()); | ||
| } | ||
| } catch (SQLException e) { | ||
| e.printStackTrace(); |
| try { | ||
| return resultSet.getObject(backreferenceName); | ||
| } catch (SQLException o_O) { | ||
| //throw new MappingException(String.format("Could not read value %s from result set!", backreferenceName), o_O); |
There was a problem hiding this comment.
Again, I don't think we should ignore exceptions.
If a column is not in the result set we should not ask for it and if it is and exception should actually get propagated.
THD-Thomas-Lang
force-pushed
the
datajdbc-341
branch
from
965e440 to
3764798
Compare
…ng fetched in the query (fixed tests)
THD-Thomas-Lang
force-pushed
the
datajdbc-341
branch
from
e4cac74 to
b287cb2
Compare
…ng fetched in the query. Original pull request: #170.
…ng fetched in the query. Original pull request: #170.
|
Thank you for your contribution. That 's merged and polished via #201. |
3 participants
Fix of issue #341 - see here: https://jira.spring.io/browse/DATAJDBC-341