DATAJDBC-113 - Polishing.

Applied changes from review.
Removed superfluous @ConstructorProperties annotations.
Fixed formatting.
Improved usage of generics.

Author: schauder

src/main/java/org/springframework/data/jdbc/core/EntityRowMapper.java

@@ -51,7 +51,6 @@ class EntityRowMapper<T> implements RowMapper<T> {
 	private final JdbcEntityOperations template;
 	private final JdbcPersistentProperty idProperty;
 
-	@java.beans.ConstructorProperties({ "entity", "conversions", "context", "template" })
 	public EntityRowMapper(JdbcPersistentEntity<T> entity, ConversionService conversions, JdbcMappingContext context,
 			JdbcEntityOperations template) {
 
@@ -137,7 +136,6 @@ private static class ResultSetParameterValueProvider implements ParameterValuePr
 		@NonNull private final ConversionService conversionService;
 		@NonNull private final String prefix;
 
-		@java.beans.ConstructorProperties({ "resultSet", "conversionService", "prefix" })
 		private ResultSetParameterValueProvider(ResultSet resultSet, ConversionService conversionService, String prefix) {
 
 			this.resultSet = resultSet;

src/main/java/org/springframework/data/jdbc/core/conversion/JdbcEntityWriter.java

@@ -126,21 +126,20 @@ private Stream<?> referencedEntity(JdbcPersistentProperty p, PersistentPropertyA
 		}
 
 		Class<?> type = p.getType();
-		if (Collection.class.isAssignableFrom(type))
-			return collectionPropertyAsStream(p, propertyAccessor);
 
-		return singlePropertyAsStream(p, propertyAccessor);
+		return Collection.class.isAssignableFrom(type) //
+				? collectionPropertyAsStream(p, propertyAccessor) //
+				: singlePropertyAsStream(p, propertyAccessor);
 	}
 
 	private Stream<Object> collectionPropertyAsStream(JdbcPersistentProperty p,
 			PersistentPropertyAccessor propertyAccessor) {
 
 		Object property = propertyAccessor.getProperty(p);
-		if (property == null) {
-			return Stream.empty();
-		}
 
-		return ((Collection<Object>) property).stream();
+		return property == null //
+				? Stream.empty() //
+				: ((Collection<Object>) property).stream();
 	}
 
 	private Stream<Object> singlePropertyAsStream(JdbcPersistentProperty p, PersistentPropertyAccessor propertyAccessor) {

src/main/java/org/springframework/data/jdbc/support/JdbcUtil.java

@@ -36,7 +36,7 @@
 @UtilityClass
 public class JdbcUtil {
 
-	private static final Map<Class, Integer> sqlTypeMappings = new HashMap<>();
+	private static final Map<Class<?>, Integer> sqlTypeMappings = new HashMap<>();
 
 	static {
 
@@ -63,7 +63,7 @@ public class JdbcUtil {
 		sqlTypeMappings.put(Timestamp.class, Types.TIMESTAMP);
 	}
 
-	public static int sqlTypeFor(Class type) {
+	public static int sqlTypeFor(Class<?> type) {
 		return sqlTypeMappings.keySet().stream() //
 				.filter(k -> k.isAssignableFrom(type)) //
 				.findFirst() //

src/test/java/org/springframework/data/jdbc/core/EntityRowMapperUnitTests.java

@@ -19,7 +19,6 @@
 import static org.assertj.core.api.Assertions.*;
 import static org.mockito.Mockito.*;
 
-import lombok.Data;
 import lombok.RequiredArgsConstructor;
 
 import java.sql.ResultSet;
@@ -191,7 +190,6 @@ private boolean isBeforeFirst() {
 		}
 
 		private Object getObject(String column) {
-
 			return values.get(index).get(column);
 		}