Skip to content

Commit ed66198

Browse files
committed
simplify statement
1 parent 57463d7 commit ed66198

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

spring-data-relational/src/test/java/org/springframework/data/relational/core/sql/render/SelectRendererUnitTests.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -239,11 +239,11 @@ void shouldRenderJoinWithInlineQueryAndWhereClause() {
239239
BindMarker merchantIdMarker = SQL.bindMarker(":merchantId");
240240

241241
Select innerSelect = Select.builder()
242-
.select(customerDetails.column("user_id").as("user_id"), customerDetails.column("user_id").as("name"))
242+
.select(customerDetails.column("user_id").as("user_id"))
243243
.from(customerDetails).join(merchantCustomers)
244244
.on(merchantCustomers.column("user_id").isEqualTo(customerDetails.column("user_id"))).where(
245-
customerDetails.column("user_id").isEqualTo(merchantCustomers.column("user_id"))
246-
.and(merchantCustomers.column("merchant_id").isEqualTo(merchantIdMarker))).build();
245+
merchantCustomers.column("merchant_id").isEqualTo(merchantIdMarker) //
246+
).build();
247247

248248
InlineQuery innerTable = InlineQuery.create(innerSelect, "inner");
249249

@@ -256,10 +256,10 @@ void shouldRenderJoinWithInlineQueryAndWhereClause() {
256256

257257
assertThat(sql).isEqualTo("SELECT merchants_customers.* FROM merchants_customers " + //
258258
"JOIN (" + //
259-
"SELECT customer_details.user_id AS user_id, customer_details.user_id AS name " + //
259+
"SELECT customer_details.user_id AS user_id " + //
260260
"FROM customer_details " + //
261261
"JOIN merchants_customers ON merchants_customers.user_id = customer_details.user_id " + //
262-
"WHERE customer_details.user_id = merchants_customers.user_id AND merchants_customers.merchant_id = :merchantId" + //
262+
"WHERE merchants_customers.merchant_id = :merchantId" + //
263263
") inner " + //
264264
"ON inner.user_id = merchants_customers.user_id");
265265
}

0 commit comments

Comments
 (0)