Skip to content

Add more test assertions for TTL command #3230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add more test assertions for TTL command #3230

wants to merge 1 commit into from

Conversation

@NeatGuyCoding
Copy link
Contributor

@NeatGuyCoding NeatGuyCoding commented Oct 7, 2025 •
edited
Loading

  • You have read the Spring Data contribution guidelines.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Oct 7, 2025
@onobc onobc self-assigned this Oct 7, 2025
onobc pushed a commit that referenced this pull request Oct 28, 2025
@NeatGuyCoding @onobc
Add more TTL test assertions.
ba319fc 
This commit adds more assertions for TTL w/ the newly added HGETEX and HSETEX commands.

Original Pull Request: #3230

Signed-off-by: NeatGuyCoding <[email protected]>
onobc added a commit that referenced this pull request Oct 28, 2025
@onobc
Polishing.
959637b 
Adds a few more TTL asssertions to JedisClusterConnectionTests and also updates the counterpart in Lettuce (LettuceClusterConnectionTests) w/ the same assertions.

See #3230

Signed-off-by: Chris Bono <[email protected]>
@onobc
Copy link
Contributor

onobc commented Oct 28, 2025

Thank you for the contribution @NeatGuyCoding !

I polished your commit a bit and added the same treatment for the Lettuce counterpart.

Closing in favor of b2b0672

@onobc onobc closed this Oct 28, 2025
@mp911de mp911de added the type: task A general task label Oct 29, 2025
@mp911de mp911de added this to the 4.0 RC2 (2025.1.0) milestone Oct 29, 2025
@mp911de mp911de changed the title add more test assertions for ttl Add more test assertions for TTL command Oct 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@onobc onobc

Labels

status: waiting-for-triage An issue we've not yet triaged type: task A general task

Projects

None yet

Milestone

4.0 RC2 (2025.1.0)

Development

Successfully merging this pull request may close these issues.

4 participants

@NeatGuyCoding @onobc @mp911de @spring-projects-issues