Skip to content

Feat/support for redis 8 vector sets #3221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Feat/support for redis 8 vector sets #3221

wants to merge 3 commits into from

Conversation

@AnneMayor
Copy link
Contributor

@AnneMayor AnneMayor commented Sep 21, 2025 •
edited
Loading

This PR implements a partial feature to validate the code conventions and assess the impact scope. If this approach aligns with the project's direction, I will proceed with implementing the remaining functionality.

Please review and let me know if this is the right approach.

AS-IS

no support for redis 8 vector set

TO-BE

add feature vAdd of redis 8 vector set for Jedis
partially resolved #3153

Next Step

  • Add support for Lettuce
  • Implement other features of redis 8 vector set
  • You have read the Spring Data contribution guidelines.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Sep 21, 2025
@AnneMayor AnneMayor force-pushed the feat/support-for-redis-8-vector-sets branch from a6f4df4 to c6f326a Compare September 21, 2025 13:40
@mp911de mp911de added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Sep 22, 2025
@AnneMayor
Copy link
Contributor Author

@mp911de I am going to go on the next step. Pleaes, let me know if I have to switch my PR direction.

mp911de
mp911de requested changes Sep 29, 2025
View reviewed changes
Copy link
Member

@mp911de mp911de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went over the PR initially and left a few comments. The general direction looks neat, we should also have a reactive implementation and we have to make up our mind how we want to surface Vector sets from the Template API.

src/main/java/org/springframework/data/redis/connection/lettuce/LettuceVectorSetCommands.java
Assert.notNull(values, "Values must not be null");
Assert.notNull(element, "Element must not be null");

// TODO: Implement when Lettuce adds native support for V.ADD
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lettuce 6.7 has support for Vector sets.

Copy link
Contributor

@tishun tishun Oct 1, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW the API surface in 6.7 is still in experimental state.
There are some pending changes that need to be addressed before we can promote it.
See redis/lettuce#3459

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback! I’ll double-check and update the PR if needed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed that lettuce has still been in experimental progress in terms of Vector API. I think we should wait until it is addressed completely. Any idea?

@AnneMayor
Copy link
Contributor Author

I went over the PR initially and left a few comments. The general direction looks neat, we should also have a reactive implementation and we have to make up our mind how we want to surface Vector sets from the Template API.

Thank you for your comments. I am gonna address your comments.

@AnneMayor
Copy link
Contributor Author

Sorry for the late response. I plan to update and re-request the PR review by this weekend. Thanks for your patience.

@AnneMayor AnneMayor force-pushed the feat/support-for-redis-8-vector-sets branch from c6f326a to 8438e4c Compare October 29, 2025 12:55
@AnneMayor AnneMayor force-pushed the feat/support-for-redis-8-vector-sets branch from 8438e4c to c1b72e5 Compare October 29, 2025 12:56
@AnneMayor AnneMayor requested a review from mp911de October 29, 2025 13:06
@AnneMayor
Copy link
Contributor Author

I think it is better to open new PR for support other vector APIs to make PR review more easier and comfortable. What do you guys think?

@mp911de mp911de added the for: planning An issue we'd like to consider when planning our next release label Oct 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mp911de mp911de Awaiting requested review from mp911de

1 more reviewer

@tishun tishun tishun left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

for: planning An issue we'd like to consider when planning our next release type: enhancement A general enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add support for Redis 8 Vector Sets

4 participants

@AnneMayor @mp911de @tishun @spring-projects-issues