Polish "Allow configuring lifecycle in listener containers".

Removes the lifecycle setters from the stream container as it should be configured via the stream options.

Also rewords the javadoc comments and moves the autoStartup get/set by the phase get/set.

Original Pull Request: #3224
Related tickets: #3208

Signed-off-by: Chris Bono <[email protected]>

Author: onobc

src/main/java/org/springframework/data/redis/listener/RedisMessageListenerContainer.java

@@ -627,14 +627,13 @@ public int getPhase() {
         return this.phase;
     }
 
-    /**
-     * Specify the lifecycle phase for this container.
-     * Lower values start earlier and stop later.
-     * The default is {@code Integer.MAX_VALUE}.
-     *
-     * @see SmartLifecycle#getPhase()
-     * @since 4.0
-     */
+	/**
+	 * Configure the lifecycle phase that this listener container is supposed to run in. The default is
+	 * {@code Integer.MAX_VALUE}.
+	 *
+	 * @see org.springframework.context.SmartLifecycle#getPhase()
+	 * @since 4.0
+	 */
     public void setPhase(int phase) {
         this.phase = phase;
     }
@@ -644,14 +643,13 @@ public boolean isAutoStartup() {
         return this.autoStartup;
     }
 
-    /**
-     * Configure if this Lifecycle connection factory should get started automatically by the container at the time that
-     * the containing ApplicationContext gets refreshed.
-     * The default is {@code true}.
-     *
-     * @see SmartLifecycle#isAutoStartup()
-     * @since 4.0
-     */
+	/**
+	 * Configure if this listener container should get started automatically at the time that the containing
+	 * {@code ApplicationContext} gets refreshed. The default is {@code true}.
+	 *
+	 * @see org.springframework.context.SmartLifecycle#isAutoStartup()
+	 * @since 4.0
+	 */
     public void setAutoStartup(boolean autoStartup) {
         this.autoStartup = autoStartup;
     }

src/main/java/org/springframework/data/redis/stream/DefaultStreamMessageListenerContainer.java

@@ -69,7 +69,7 @@ class DefaultStreamMessageListenerContainer<K, V extends Record<K, ?>> implement
 	private boolean running = false;
 
     private int phase = Integer.MAX_VALUE;
-    private boolean autoStartup = false;
+    private boolean autoStartup;
 
 	/**
 	 * Create a new {@link DefaultStreamMessageListenerContainer}.
@@ -95,11 +95,11 @@ class DefaultStreamMessageListenerContainer<K, V extends Record<K, ?>> implement
 			this.streamOperations = this.template.opsForStream();
 		}
 
-        if(containerOptions.isAutoStartup().isPresent()){
+        if (containerOptions.isAutoStartup().isPresent()) {
             this.autoStartup = containerOptions.isAutoStartup().get();
         }
 
-        if(containerOptions.getPhase().isPresent()){
+        if (containerOptions.getPhase().isPresent()) {
             this.phase = containerOptions.getPhase().getAsInt();
         }
 	}
@@ -133,23 +133,6 @@ private RedisTemplate<K, V> createRedisTemplate(RedisConnectionFactory connectio
 		return template;
 	}
 
-	@Override
-	public boolean isAutoStartup() {
-		return this.autoStartup;
-	}
-
-    /**
-     * Configure if this Lifecycle connection factory should get started automatically by the container at the time that
-     * the containing ApplicationContext gets refreshed.
-     * The default is {@code false}.
-     *
-     * @see org.springframework.context.SmartLifecycle#isAutoStartup()
-     * @since 4.0
-     */
-    public void setAutoStartup(boolean autoStartup) {
-        this.autoStartup = autoStartup;
-    }
-
 	@Override
 	public void stop(Runnable callback) {
 
@@ -204,17 +187,10 @@ public int getPhase() {
 		return this.phase;
 	}
 
-    /**
-     * Specify the lifecycle phase for this container.
-     * Lower values start earlier and stop later.
-     * The default is {@code Integer.MAX_VALUE}.
-     *
-     * @see org.springframework.context.SmartLifecycle#getPhase()
-     * @since 4.0
-     */
-    public void setPhase(int phase) {
-        this.phase = phase;
-    }
+	@Override
+	public boolean isAutoStartup() {
+		return this.autoStartup;
+	}
 
 	@Override
 	public Subscription register(StreamReadRequest<K> streamRequest, StreamListener<K, V> listener) {

src/main/java/org/springframework/data/redis/stream/StreamMessageListenerContainer.java

@@ -605,15 +605,17 @@ public Executor getExecutor() {
 		}
 
         /**
-         * @return the phase.
+         * @return the configured phase to use for the container lifecycle or {@code empty} if the phase was not
+		 * specified on the options.
          * @since 4.0
          */
         public OptionalInt getPhase() {
             return phase != null ? OptionalInt.of(phase) : OptionalInt.empty();
         }
 
         /**
-         * @return the autoStartup.
+         * @return the configured autoStartup to use for the container lifecycle or {@code empty} if the autoStartup
+		 * was not specified on the options.
          * @since 4.0
          */
         public Optional<Boolean> isAutoStartup() {
@@ -703,7 +705,7 @@ public StreamMessageListenerContainerOptionsBuilder<K, V> errorHandler(ErrorHand
 		}
 
         /**
-         * Configure a phase for the {@link SmartLifecycle}
+         * Configure the phase to use for the container {@link SmartLifecycle}
          *
          * @return {@code this} {@link StreamMessageListenerContainerOptionsBuilder}.
          * @since 4.0
@@ -714,7 +716,7 @@ public StreamMessageListenerContainerOptionsBuilder<K, V> phase(int phase) {
         }
 
         /**
-         * Configure a autoStartup for the {@link SmartLifecycle}
+         * Configure the autoStartup to use for the container {@link SmartLifecycle}
          *
          * @return {@code this} {@link StreamMessageListenerContainerOptionsBuilder}.
          * @since 4.0