Add support of DataSource configuration

[hantsy]

Currently Spring data Jdbc/JPA can recognize spring.datasource and build a DataSource bean, if possible create a ConnectionFactory bean from spring.datasource automatically if it is configured in Spring Boot applications?

[gregturn]

I’m not in favor of this. DataSource is used by JDBC and JPA. It would drag in assumptions and possible legacy maintenance requirements.

Since r2dbc is targeting a new approach we have achieved much by not being tied down to old specs and backwards compatibility.

I’ll wait to see what the other contributors have to say.

[mp911de]

We should avoid depending on JDBC in the first place. JDBC is in any case a non-core module in the JDK originating in Java Enterprise. So it could suffer from what happened to non-core modules in the past few Java 9+ releases. There’s a need to provide a convenient configuration mechanism (such as URI-based configuration). This might happen in R2DBC SPI itself so we gain a consistent config mechanism for drivers and client implementors. Final note: Spring Data R2DBC currently depends on JDBC because we’re reusing Spring Frameworks Exception Translation. This is subject to be fixed as soon as Spring Framework refractors it’s mechanism. Am 21. Dez. 2018, 14:27 +0100 schrieb Greg Turnquist <notifications@github.com>:

…

I’m not in favor of this. DataSource is used by JDBC and JPA. It would drag in assumptions and possible legacy maintenance requirements. Since r2dbc is targeting a new approach we have achieved much by not being tied down to old specs and backwards compatibility. I’ll wait to see what the other contributors have to say. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

[odrotbohm]

For reference, I've created SPR-17618 to ask for the extraction of the error code translation mechanism.

[mp911de]

Spring Data R2DBC provides AbstractR2dbcConfiguration as configuration support. spring.datasource properties belong into Spring Boot and we should see support for spring.r2dbc properties in the future. In any case, auto-configuration components will be part of an external project so I'm closing this ticket as invalid for now.