DATAMONGO-2089 - Add fluent change stream API to ReactiveMongoTemplate. #751
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mp911de
reviewed
May 28, 2019
Member
mp911de
left a comment
mp911de
left a comment
There was a problem hiding this comment.
Let's also add Kotlin extensions for reified generics and for the as -> asType method.
| * | ||
| * @return new instance of {@link ReactiveFind}. Never {@literal null}. | ||
| */ | ||
| ReactiveChangeStream<Document> changeStream(); |
Member
There was a problem hiding this comment.
Should we drop this method in favor of changeStream(Document.class)?
| * @see ChangeStreamOptionsBuilder#resumeAt(BsonTimestamp) | ||
| * @throws IllegalArgumentException if the given beacon is neither {@link Instant} nor {@link BsonTimestamp}. | ||
| */ | ||
| TerminatingChangeStream<T> resumeAt(Object beacon); |
| * Consider limiting events be defining a {@link ChangeStreamWithCollection#watchCollection(String) collection} and/or | ||
| * {@link ChangeStreamWithFilter#filter(CriteriaDefinition) filter}. | ||
| * | ||
| * @return new instance of {@link ReactiveFind}. Never {@literal null}. |
Member
There was a problem hiding this comment.
Nit: ReactiveChangeStream instead of ReactiveFind.
| /** | ||
| * Result type override (optional). | ||
| */ | ||
| interface ChangeStreamWithProjection<T> extends ChangeStreamWithFilter<T> { |
Member
There was a problem hiding this comment.
Probably we should inline this interface into ChangeStreamWithFilter. ChangeStreamWithFilter.filter returns ChangeStreamWithProjection and as(…) returns ChangeStreamWithFilter.
We now offer a fluent API for more intuitive change stream interaction.
Flux<ChangeStreamEvent<User>> flux = reactiveTemplate.changeStream()
.watchCollection("persons")
.filter(where("age").gte(38))
.as(User.class)
.listen();
christophstrobl
force-pushed
the
issue/DATAMONGO-2089
branch
from
eeec44f to
03531a2
Compare
mp911de
pushed a commit
that referenced
this pull request
Jul 3, 2019
We now offer a fluent API for more intuitive change stream interaction.
Flux<ChangeStreamEvent<User>> flux = reactiveTemplate.changeStream(User.class)
.watchCollection("people")
.filter(where("age").gte(38))
.listen();
Original pull request: #751.
mp911de
added a commit
that referenced
this pull request
Jul 3, 2019
Add watchCollection(…) accepting an entity class. Use static import for assertions. Tweak javadoc. Original pull request: #751.
Member
|
That's merged and polished now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now offer a fluent API for more intuitive change stream interaction.