Skip to content

Fix date setup in tests #4447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Fix date setup in tests #4447

wants to merge 3 commits into from

Conversation

@sxhinzvc
Copy link
Contributor

@sxhinzvc sxhinzvc commented Jul 13, 2023

Closes #4446

@pivotal-cla
Copy link

pivotal-cla commented Jul 13, 2023

@sxhinzvc Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jul 13, 2023
@pivotal-cla
Copy link

pivotal-cla commented Jul 13, 2023

@sxhinzvc Thank you for signing the Contributor License Agreement!

@sxhinzvc sxhinzvc requested a review from christophstrobl July 13, 2023 17:44
@christophstrobl
Copy link
Member

christophstrobl commented Jul 14, 2023

LGTM.
You may want to add yourself as @author to the files modified.

I think we could even simplify the testsetup a little further by using AbstractEncryptionTestBase.EncryptionConfig directly in EncryptionTests and remove superfluous methods from the BypassAutoEncryptionTest.Config leaving only configureClientSettings in place. This change could go into a separate polishing commit. WDYT?

@christophstrobl christophstrobl marked this pull request as ready for review July 17, 2023 08:05
christophstrobl pushed a commit that referenced this pull request Jul 17, 2023
@sxhinzvc @christophstrobl
Fix test setup so that temporal conversions use symmetric timezone se…
5407456 
…tting.

Closes: #4446
Original Pull Request: #4447
christophstrobl pushed a commit that referenced this pull request Jul 17, 2023
@sxhinzvc @christophstrobl
Polishing.
e198637 
Remove duplicate test configuration.

Original Pull Request: #4447
christophstrobl pushed a commit that referenced this pull request Jul 17, 2023
@sxhinzvc @christophstrobl
Fix test setup so that temporal conversions use symmetric timezone se…
529a0c7 
…tting.

Closes: #4446
Original Pull Request: #4447
@christophstrobl christophstrobl deleted the issue/4446 branch July 17, 2023 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christophstrobl christophstrobl Awaiting requested review from christophstrobl

Assignees

No one assigned

Labels

status: waiting-for-triage An issue we've not yet triaged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Some tests failing depending on timezone

5 participants

@sxhinzvc @pivotal-cla @christophstrobl @spring-projects-issues