Introduce @MongoId to customize Id conversion [DATAMONGO-1798]

[spring-projects-issues]

Daniel Sass opened DATAMONGO-1798 and commented

Hi,

we're using Spring Boot 1.5.7 with the according MongoDB starter and have a collection where we use external ids as MongoDB _ids. This works fine unless we have ids with 24 digits. The ObjectMapper.convertId(Object id) checks if the id is a String and if the id is a valid object id with ObjectId.isValid(). The raw id is than converted to an ObjectId which is wrong. The document isn't found in this case because the spring data searches now for an oid:

findOne using query: { "_id" : { "$oid" : "151139921910640945084286"}} in db.collection: content.term

For all other string ids the query is correct:

findOne using query: { "_id" : "01200314690800000235"} in db.collection: content.term

The implementation leads to inconsistent behaviour in case of 24 digit string ids. IHMO there are two choices:

1. fall back to the _id search if nothing is found for the $oid search
2. add an additional annotation on the @Id field to make that behaviour explicit

My favour is option 2

Thanks,
Daniel

---

Affects: 2.1 RC2 (Lovelace), 2.0.10 (Kay SR10), 1.10.15 (Ingalls SR15)

Attachments:

• com.sap.content.tag.zip (19.96 kB)

Issue Links:

• DATAMONGO-2202 Document how to insert _id field as String and not ObjectId

• DATAMONGO-1988 String ID not working for embeded objects

• DATAMONGO-879 Create @ObjectId Annotation
  ("supersedes")

Referenced from: pull request #617, and commits 62dcda9, 6f8f7cd, 4c6f793, 5d39191, 74b9ea9, f88b161, b9bba63

4 votes, 6 watchers

[spring-projects-issues]

Daniel Sass commented

Hi, any update here if this will be fixed?

Thanks,
Daniel

[spring-projects-issues]

Christoph Strobl commented

@CanD42 the issue sounds like the one resolved via DATAMONGO-1988 (Ingalls SR13). However Spring Boot 1.5.7 pulls in the Spring Data release train Ingalls SR7. Would you mind checking with a more recent Spring Boot version. The fix should be available as off Boot 1.5.14

[spring-projects-issues]

Gabriella Gógl-György commented

Hi Christoph Strobl, we are on version 2.0.4 and the issue is still present

[spring-projects-issues]

Christoph Strobl commented

@Tamira90 Boot 2.0.4 or Spring Data MongoDB?

[spring-projects-issues]

Daniel Sass commented

@Christoph Strobl I just also tested Spring Boot 2.0.5 and got the same result: if the tag id is 24 chars long the query is changed to an $oid search like here:

http://localhost:8080/contents/search/findByStatusAndObjectTypeInAndTagsIdIn?status=published&objectTypes=blogpost&ids=156805312755941004032364
find using query: { "status" : "published", "objectType" : { "$in" : ["blogpost"] }, "tags._id" : { "$in" : [{ "$oid" : "156805312755941004032364" }] } }

for other length the query is working fine like this one

http://localhost:8080/contents/search/findByStatusAndObjectTypeInAndTagsIdIn?status=published&objectTypes=blogpost&ids=571267881358674984386133031541144

find using query: { "status" : "published", "objectType" : { "$in" : ["blogpost"] }, "tags._id" : { "$in" : ["571267881358674984386133031541144"] } }

so we have that problem for the content collection which has an embedded document with a tag id and in the tag collection itself

 

 

[spring-projects-issues]

Christoph Strobl commented

thanks for checking - any chance you can point me to an app/test I can actually run?

[spring-projects-issues]

Daniel Sass commented

I attached an archive containing a text file describing how to reproduce the issues and our spring boot app stripped down to the bare minimum to show the problem. Thanks

I think the problem lies in the fact that we import the data via Python into MongoDB and the REST API is using Spring Data REST for serving the data. The Python app imports the according 24-char-tag-ids just as strings and not as ObjectIds as Spring Data would

[spring-projects-issues]

Christoph Strobl commented

thanks CanD42, yes the import seems to be the culprit. We strive to have read/write symetry in the lib itself. We'll see if we can come up with an addition that let's you preserve the values as Strings

[spring-projects-issues]

Mark Paluch commented

I renamed the ticket to reflect we introduced a new feature