Skip to content

Conversation

@qxo
Copy link
Contributor

@qxo qxo commented Sep 30, 2020

ie:

logging.pattern.charset=UTF-8
logging.pattern.charset=GBK

ie:
```
logging.pattern.charset=UTF-8
```

```
logging.pattern.charset=GBK
```
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Sep 30, 2020
@wilkinsona wilkinsona changed the title fix: logback PatternLayoutEncoder charset configable Provide a configuration property for setting the charset on Logback's PatternLayoutEncoder Sep 30, 2020
@wilkinsona
Copy link
Member

Thanks for the pull request. I'm wondering how common it is to want to write log files using an encoding that differs from the JVM's default. What's your usecase for using a different encoding?

@wilkinsona wilkinsona added the status: waiting-for-feedback We need additional information before we can continue label Sep 30, 2020
@qxo
Copy link
Contributor Author

qxo commented Sep 30, 2020

Thanks for the pull request. I'm wondering how common it is to want to write log files using an encoding that differs from the JVM's default. What's your usecase for using a different encoding?

Yes, for native language was not english.

Such as using os with GBK(chinese), but for some reason using UTF-8 as app default charset, in order to fix console display issue, we have to set right charset for console

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels Sep 30, 2020
@philwebb philwebb added the for: team-attention An issue we'd like other members of the team to review label Sep 30, 2020
@philwebb philwebb self-assigned this Oct 7, 2020
@philwebb philwebb added for: merge-with-amendments Needs some changes when we merge type: enhancement A general enhancement and removed for: team-attention An issue we'd like other members of the team to review status: feedback-provided Feedback has been provided status: waiting-for-triage An issue we've not yet triaged labels Oct 7, 2020
@philwebb philwebb added this to the 2.4.x milestone Oct 7, 2020
@philwebb philwebb changed the title Provide a configuration property for setting the charset on Logback's PatternLayoutEncoder Provide a configuration property for setting the logging charset Oct 23, 2020
@philwebb
Copy link
Member

Thanks for the pull-request @qxo. The recent changes made for #23609 have unfortunately made it impossible to merge this in its current form. I've opened #23827 to look at adding the feature in a different way.

@philwebb philwebb closed this Oct 24, 2020
@philwebb philwebb added status: superseded An issue that has been superseded by another and removed for: merge-with-amendments Needs some changes when we merge type: enhancement A general enhancement labels Oct 24, 2020
@philwebb philwebb removed this from the 2.4.x milestone Oct 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: superseded An issue that has been superseded by another

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants