Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider delaying Jackson 2.17.0 upgrade in Spring Boot 3.3.0 #40489

Closed
zerda opened this issue Apr 23, 2024 · 4 comments
Closed

Consider delaying Jackson 2.17.0 upgrade in Spring Boot 3.3.0 #40489

zerda opened this issue Apr 23, 2024 · 4 comments
Labels
status: declined A suggestion or change that we don't feel we should currently apply

Comments

@zerda
Copy link

zerda commented Apr 23, 2024

The LockFreePool which was the default RecyclerPool implementation in Jackson 2.17.0, has been found to have performance issues. FasterXML/jackson-core#1260

This was addressed in the upcoming version 2.17.1, where the default implementation was reverted back to threadLocalPool(). FasterXML/jackson-core#1260

In the context of Spring Boot, there was an upgrade to Jackson 2.17.0 in the commit 437c654. However, considering the performance issues with the LockFreePool implementation in Jackson 2.17.0, it might be advisable to delay this upgrade unless there are strict requirements. @wilkinsona

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Apr 23, 2024
@wilkinsona
Copy link
Member

Thanks for the suggestion. I would prefer to use Jackson 2.17.x for the Spring Boot 3.3.x generation rather than getting stuck on 2.16.x for the sake of an issue that will be fixed shortly in Jackson 2.17.1. Hopefully 2.17.1 will be released before 3.3.0 GAs on 23 May. If not, we will pick it up as soon after that date as we can.

/cc @cowtowncoder

@wilkinsona wilkinsona closed this as not planned Won't fix, can't repro, duplicate, stale Apr 23, 2024
@wilkinsona wilkinsona added status: declined A suggestion or change that we don't feel we should currently apply and removed status: waiting-for-triage An issue we've not yet triaged labels Apr 23, 2024
@cowtowncoder
Copy link

Yeah I am planning to do 2.17.1 release soon enough, hopefully next week. And definitely before 23 May.

@cowtowncoder
Copy link

Jackson 2.17.1 is now released; release notes:

https://github.com/FasterXML/jackson/wiki/Jackson-Release-2.17.1

(Scala module still to be released; all other modules done, available from Maven Central)

@wilkinsona
Copy link
Member

Thanks very much, @cowtowncoder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: declined A suggestion or change that we don't feel we should currently apply
Projects
None yet
Development

No branches or pull requests

4 participants