Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BackgroundPreinitializer doesn't work with AOT #14157

Closed
dsyer opened this issue Aug 21, 2018 · 3 comments
Closed

BackgroundPreinitializer doesn't work with AOT #14157

dsyer opened this issue Aug 21, 2018 · 3 comments
Assignees
Labels
for: external-project For an external project and not something we can fix theme: aot An issue related to Ahead-of-time processing

Comments

@dsyer
Copy link
Member

dsyer commented Aug 21, 2018

The BackgroundPreinitializer is written in a style of try/catch/swallow to deal with classes that aren't available at runtime. It's easier on the eye than checking for each class before trying to use it, but it doesn't work with Graal AOT (the BackgroundPreinitializer just errors out on line 83, the Tomcat MBeans, if Tomcat is not on the classpath, and then never recovers).

Possibly related oracle/graal#622 and #14147

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Aug 21, 2018
@snicoll snicoll added the for: team-attention An issue we'd like other members of the team to review label Aug 27, 2018
@philwebb
Copy link
Member

Tempted to see how oracle/graal#622 plays out before we rush to change this. I imagine we've a more cases like that.

@philwebb philwebb self-assigned this Aug 29, 2018
@philwebb philwebb added theme: graal for: external-project For an external project and not something we can fix and removed for: team-attention An issue we'd like other members of the team to review status: waiting-for-triage An issue we've not yet triaged labels Aug 29, 2018
@philwebb
Copy link
Member

@dsyer I've added a new label called theme: graal to track all these related issues. I think we'll need to wait for Spring Boot 2.2 before we can really tackle it in any meaningful form. Probably the first one we should fix is #14216 so that we can have a CI for it.

It looks like oracle/graal#622 has been accepted so I'll close this one with the hope that they fix it in the VM. If they can't/won't fix the VM issue then we can reopen this one.

@philwebb
Copy link
Member

BTW: Feel free to add the theme label to any issues I missed.

@mbhave mbhave added the theme: aot An issue related to Ahead-of-time processing label Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
for: external-project For an external project and not something we can fix theme: aot An issue related to Ahead-of-time processing
Projects
None yet
Development

No branches or pull requests

5 participants