Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ServletListenerRegistrationBean should not extends RegistrationBean #11344

Closed
philwebb opened this issue Dec 13, 2017 · 2 comments
Closed

ServletListenerRegistrationBean should not extends RegistrationBean #11344

philwebb opened this issue Dec 13, 2017 · 2 comments
Assignees
@philwebb
Labels
type: enhancement A general enhancement
Milestone
2.0.0.RC1

Comments

@philwebb
Copy link
Member

See #11342
@philwebb philwebb added this to the 2.0.0.RC1 milestone Dec 13, 2017
@philwebb philwebb self-assigned this Dec 13, 2017
@snicoll
Copy link
Member

snicoll commented Jan 4, 2018

@philwebb I tried to give this a quick try and got stuck because ServletContextInitializerBeans expects it to be a RegistrationBean. And there is an adapter that would be useless/invalid now

@snicoll snicoll added status: waiting-for-feedback We need additional information before we can continue priority: normal type: enhancement A general enhancement labels Jan 4, 2018
@philwebb
Copy link
Member Author

philwebb commented Jan 9, 2018

@snicoll Good point. I've kept RegistrationBean but extracted dynamic registration concerns to a new DynamicRegistrationBean subclass.

@snicoll snicoll removed the status: waiting-for-feedback We need additional information before we can continue label Jan 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@philwebb philwebb

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
2.0.0.RC1
Development

No branches or pull requests
2 participants
@snicoll @philwebb