Use of logback.groovy results in double output.

[PeterNSteinmetz]

If one replaces logback.xml with a logback.groovy file and eliminates the logback.xml file, the program produces two copies of each log item.

It is as though there are two appenders created. Seems likely spring-boot is not checking for logback.groovy to suppress its own logging configuration, as it does with logback.xml.

This is with 1.1.1-RELEASE.

[dsyer]

Works for me. How about a little sample project?

[dsyer]

No response?

[faroe228]

I had a similar issue today with Spring Boot (v1.1.5.RELEASE) causing double log output. It turns out logback.groovy was getting executed twice (logback.xml works fine).

My workaround was to rename logback.groovy to logbackx.groovy and update the application.properties file with:

logging.config=classpath:logbackx.groovy

[dsyer]

A pull request at https://github.com/spring-projects/spring-boot-issues with a sample project would still be very helpful.

[faroe228]

I created a test example project at:

https://github.com/faroe228/spring-boot-issues/tree/master/gh-1091-groovy-logback

[faroe228]

Another observation: renaming logback.groovy to logback-test.groovy also works properly for Spring Boot (v1.1.5.RELEASE) and there is no need to update the application.properties file.

[philwebb]

The logback.groovy file is being invoked more than once, but I'm not sure if there is much that we can do about that or if it is an issue.

The first invocation comes from logback itself:

Thread [main] (Suspended (breakpoint at line 786 in System))    
    System.setProperty(String, String) line: 786    
    NativeMethodAccessorImpl.invoke0(Method, Object, Object[]) line: not available [native method]  
    NativeMethodAccessorImpl.invoke(Object, Object[]) line: 62  
    DelegatingMethodAccessorImpl.invoke(Object, Object[]) line: 43  
    Method.invoke(Object, Object...) line: 483  
    CachedMethod.invoke(Object, Object[]) line: 90  
    CachedMethod(MetaMethod).doMethodInvoke(Object, Object[]) line: 324 
    StaticMetaMethodSite$StaticMetaMethodSiteNoUnwrap.invoke(Object, Object[]) line: 130    
    StaticMetaMethodSite$StaticMetaMethodSiteNoUnwrap(StaticMetaMethodSite).call(Object, Object[]) line: 88 
    CallSiteArray.defaultCall(CallSite, Object, Object[]) line: 45  
    AbstractCallSite.call(Object, Object[]) line: 108   
    AbstractCallSite.call(Object, Object, Object) line: 120 
    Script1.run() line: 96  
    Script1$run.call(Object, Object[]) line: not available  
    CallSiteArray.defaultCall(CallSite, Object, Object[]) line: 45  
    AbstractCallSite.call(Object, Object[]) line: 108   
    AbstractCallSite.call(Object) line: 112 
    GafferConfigurator.run(String) line: 77 
    GafferConfigurator$run.callCurrent(GroovyObject, Object[]) line: not available  
    CallSiteArray.defaultCallCurrent(CallSite, GroovyObject, Object[]) line: 49 
    AbstractCallSite.callCurrent(GroovyObject, Object[]) line: 133  
    AbstractCallSite.callCurrent(GroovyObject, Object) line: 141    
    GafferConfigurator.run(URL) line: 44    
    GafferUtil.runGafferConfiguratorOn(LoggerContext, Object, URL) line: 43 
    ContextInitializer.configureByResource(URL) line: 66    
    ContextInitializer.autoConfig() line: 150   
    StaticLoggerBinder.init() line: 85  
    StaticLoggerBinder.<clinit>() line: 55  
    LoggerFactory.bind() line: 129  
    LoggerFactory.performInitialization() line: 108 
    LoggerFactory.getILoggerFactory() line: 302 
    LoggerFactory.getLogger(String) line: 276   
    SLF4JLogFactory.getInstance(String) line: 156   
    SLF4JLogFactory.getInstance(Class) line: 132    
    LogFactory.getLog(Class) line: 274  
    SpringApplication.<init>(Object...) line: 160   
    SpringApplication.run(Object[], String[]) line: 952 
    SpringApplication.run(Object, String...) line: 941  
    Application.main(String[]) line: 17 
    NativeMethodAccessorImpl.invoke0(Method, Object, Object[]) line: not available [native method]  
    NativeMethodAccessorImpl.invoke(Object, Object[]) line: 62  
    DelegatingMethodAccessorImpl.invoke(Object, Object[]) line: 43  
    Method.invoke(Object, Object...) line: 483  
    MainMethodRunner.run() line: 53 
    Thread.run() line: 745  

The second is from our custom log initialization:

Thread [main] (Suspended (breakpoint at line 786 in System))    
    System.setProperty(String, String) line: 786    
    NativeMethodAccessorImpl.invoke0(Method, Object, Object[]) line: not available [native method]  
    NativeMethodAccessorImpl.invoke(Object, Object[]) line: 62  
    DelegatingMethodAccessorImpl.invoke(Object, Object[]) line: 43  
    Method.invoke(Object, Object...) line: 483  
    CachedMethod.invoke(Object, Object[]) line: 90  
    CachedMethod(MetaMethod).doMethodInvoke(Object, Object[]) line: 324 
    StaticMetaMethodSite$StaticMetaMethodSiteNoUnwrap.invoke(Object, Object[]) line: 130    
    StaticMetaMethodSite$StaticMetaMethodSiteNoUnwrap(StaticMetaMethodSite).call(Object, Object[]) line: 88 
    CallSiteArray.defaultCall(CallSite, Object, Object[]) line: 45  
    AbstractCallSite.call(Object, Object[]) line: 108   
    AbstractCallSite.call(Object, Object, Object) line: 120 
    Script1.run() line: 96  
    Script1$run.call(Object, Object[]) line: not available  
    CallSiteArray.defaultCall(CallSite, Object, Object[]) line: 45  
    Script1$run.call(Object) line: not available    
    GafferConfigurator.run(String) line: 77 
    GafferConfigurator$run.callCurrent(GroovyObject, Object) line: not available    
    GafferConfigurator.run(URL) line: 44    
    GafferUtil.runGafferConfiguratorOn(LoggerContext, Object, URL) line: 43 
    ContextInitializer.configureByResource(URL) line: 66    
    LogbackLoggingSystem.initialize(String) line: 101   
    LogbackLoggingSystem(AbstractLoggingSystem).initialize() line: 53   
    LoggingApplicationListener.initializeSystem(ConfigurableEnvironment, LoggingSystem) line: 209   
    LoggingApplicationListener.initialize(ConfigurableEnvironment, ClassLoader) line: 152   
    LoggingApplicationListener.onApplicationEvent(ApplicationEvent) line: 126   
    SimpleApplicationEventMulticaster.multicastEvent(ApplicationEvent) line: 98 
    EventPublishingRunListener.publishEvent(SpringApplicationEvent) line: 100   
    EventPublishingRunListener.environmentPrepared(ConfigurableEnvironment) line: 59    
    SpringApplication.run(String...) line: 284  
    SpringApplication.run(Object[], String[]) line: 952 
    SpringApplication.run(Object, String...) line: 941  
    Application.main(String[]) line: 17 
    NativeMethodAccessorImpl.invoke0(Method, Object, Object[]) line: not available [native method]  
    NativeMethodAccessorImpl.invoke(Object, Object[]) line: 62  
    DelegatingMethodAccessorImpl.invoke(Object, Object[]) line: 43  
    Method.invoke(Object, Object...) line: 483  
    MainMethodRunner.run() line: 53 
    Thread.run() line: 745

I don't see duplicate log entries in the output but one thing that we could try is calling reset() on the LoggerContext before the second initialization. I'll commit a fix for that and lets see where that takes us.

[philwebb]

Could you try the latest snapshots to see if you can reproduce the double output error. I've also merge gh-1091 into the issues repository. If you manage to make that sample fail with double logging please send an updated PR.

Cheers.