Skip to content

Commit 816f434

Browse files
committed
Address comments from code review
1 parent ae27c93 commit 816f434

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

spring-boot-project/spring-boot-actuator-autoconfigure/src/main/java/org/springframework/boot/actuate/autoconfigure/metrics/export/dynatrace/DynatraceProperties.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,13 +20,15 @@
2020
import org.springframework.boot.actuate.autoconfigure.metrics.export.properties.StepRegistryProperties;
2121
import org.springframework.boot.context.properties.ConfigurationProperties;
2222

23+
import java.util.Collections;
2324
import java.util.Map;
2425

2526
/**
2627
* {@link ConfigurationProperties @ConfigurationProperties} for configuring Dynatrace
2728
* metrics export.
2829
*
2930
* @author Andy Wilkinson
31+
* @author Georg Pirklbauer
3032
* @since 2.1.0
3133
*/
3234
@ConfigurationProperties(prefix = "management.metrics.export.dynatrace")
@@ -156,7 +158,7 @@ public void setEnrichWithOneAgentMetadata(Boolean enrichWithOneAgentMetadata) {
156158
}
157159

158160
public Map<String, String> getDefaultDimensions() {
159-
return defaultDimensions;
161+
return defaultDimensions != null ? Collections.unmodifiableMap(defaultDimensions) : null;
160162
}
161163

162164
public void setDefaultDimensions(Map<String, String> defaultDimensions) {

spring-boot-project/spring-boot-actuator-autoconfigure/src/test/java/org/springframework/boot/actuate/autoconfigure/metrics/export/dynatrace/DynatracePropertiesConfigAdapterTests.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,13 +21,15 @@
2121
import org.junit.jupiter.api.Test;
2222

2323
import java.util.HashMap;
24+
import java.util.Map;
2425

2526
import static org.assertj.core.api.Assertions.assertThat;
2627

2728
/**
2829
* Tests for {@link DynatracePropertiesConfigAdapter}.
2930
*
3031
* @author Andy Wilkinson
32+
* @author Georg Pirklbauer
3133
*/
3234
class DynatracePropertiesConfigAdapterTests {
3335

0 commit comments

Comments
 (0)