Skip to content

Commit 4ff13b8

Browse files
committed
Apply RSocketConnectorConfigurer beans to the RSocketRequester.Builder
1 parent 199bc2d commit 4ff13b8

File tree

2 files changed

+30
-2
lines changed

2 files changed

+30
-2
lines changed

spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/rsocket/RSocketRequesterAutoConfiguration.java

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,13 +19,15 @@
1919
import io.rsocket.transport.netty.server.TcpServerTransport;
2020
import reactor.netty.http.server.HttpServer;
2121

22+
import org.springframework.beans.factory.ObjectProvider;
2223
import org.springframework.boot.autoconfigure.AutoConfigureAfter;
2324
import org.springframework.boot.autoconfigure.EnableAutoConfiguration;
2425
import org.springframework.boot.autoconfigure.condition.ConditionalOnClass;
2526
import org.springframework.boot.autoconfigure.condition.ConditionalOnMissingBean;
2627
import org.springframework.context.annotation.Bean;
2728
import org.springframework.context.annotation.Configuration;
2829
import org.springframework.context.annotation.Scope;
30+
import org.springframework.messaging.rsocket.RSocketConnectorConfigurer;
2931
import org.springframework.messaging.rsocket.RSocketRequester;
3032
import org.springframework.messaging.rsocket.RSocketStrategies;
3133

@@ -37,6 +39,7 @@
3739
* requester instances with different configurations.
3840
*
3941
* @author Brian Clozel
42+
* @author Nguyen Bao Sach
4043
* @since 2.2.0
4144
*/
4245
@Configuration(proxyBeanMethods = false)
@@ -47,8 +50,11 @@ public class RSocketRequesterAutoConfiguration {
4750
@Bean
4851
@Scope("prototype")
4952
@ConditionalOnMissingBean
50-
public RSocketRequester.Builder rSocketRequesterBuilder(RSocketStrategies strategies) {
51-
return RSocketRequester.builder().rsocketStrategies(strategies);
53+
public RSocketRequester.Builder rSocketRequesterBuilder(RSocketStrategies strategies,
54+
ObjectProvider<RSocketConnectorConfigurer> connectorConfigurers) {
55+
return connectorConfigurers.orderedStream()
56+
.collect(RSocketRequester::builder, RSocketRequester.Builder::rsocketConnector, (first, second) -> {
57+
}).rsocketStrategies(strategies);
5258
}
5359

5460
}

spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/rsocket/RSocketRequesterAutoConfigurationTests.java

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,13 +16,17 @@
1616

1717
package org.springframework.boot.autoconfigure.rsocket;
1818

19+
import java.util.List;
20+
1921
import org.junit.jupiter.api.Test;
2022

2123
import org.springframework.boot.autoconfigure.AutoConfigurations;
2224
import org.springframework.boot.test.context.runner.ApplicationContextRunner;
2325
import org.springframework.context.annotation.Bean;
2426
import org.springframework.context.annotation.Configuration;
27+
import org.springframework.messaging.rsocket.RSocketConnectorConfigurer;
2528
import org.springframework.messaging.rsocket.RSocketRequester;
29+
import org.springframework.test.util.ReflectionTestUtils;
2630

2731
import static org.assertj.core.api.Assertions.assertThat;
2832
import static org.mockito.Mockito.mock;
@@ -31,6 +35,7 @@
3135
* Tests for {@link RSocketRequesterAutoConfiguration}
3236
*
3337
* @author Brian Clozel
38+
* @author Nguyen Bao Sach
3439
*/
3540
class RSocketRequesterAutoConfigurationTests {
3641

@@ -59,6 +64,23 @@ void shouldNotCreateBuilderIfAlreadyPresent() {
5964
});
6065
}
6166

67+
@SuppressWarnings("unchecked")
68+
@Test
69+
void rSocketConnectorConfigurersArePickedUp() {
70+
RSocketConnectorConfigurer first = mock(RSocketConnectorConfigurer.class);
71+
RSocketConnectorConfigurer second = mock(RSocketConnectorConfigurer.class);
72+
this.contextRunner.withBean("firstRSocketConnectorConfigurer", RSocketConnectorConfigurer.class, () -> first)
73+
.withBean("secondRSocketConnectorConfigurer", RSocketConnectorConfigurer.class, () -> second)
74+
.run((context) -> {
75+
assertThat(context).getBeans(RSocketConnectorConfigurer.class).hasSize(2);
76+
77+
RSocketRequester.Builder builder = context.getBean(RSocketRequester.Builder.class);
78+
List<RSocketConnectorConfigurer> rsocketConnectorConfigurers = (List<RSocketConnectorConfigurer>) ReflectionTestUtils
79+
.getField(builder, "rsocketConnectorConfigurers");
80+
assertThat(rsocketConnectorConfigurers).containsExactly(first, second);
81+
});
82+
}
83+
6284
@Configuration(proxyBeanMethods = false)
6385
static class CustomRSocketRequesterBuilder {
6486

0 commit comments

Comments
 (0)